* dmaengine: rcar-dmac: convert to SPDX identifiers
@ 2018-07-03 6:25 Laurent Pinchart
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2018-07-03 6:25 UTC (permalink / raw)
To: Vinod
Cc: Kuninori Morimoto, Geert Uytterhoeven, Dan Williams, Magnus Damm,
Linux-Renesas, Kieran Bingham, Geert Uytterhoeven, dmaengine,
Hiroki Negishi
Hi Vinod,
On Tuesday, 3 July 2018 09:20:08 EEST Vinod wrote:
> On 03-07-18, 08:49, Laurent Pinchart wrote:
> > Hi Morimoto-san,
> >
> > Thank you for the patch.
> >
> > On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > A commit message would be nice :-)
> >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > >
> > > drivers/dma/sh/rcar-dmac.c | 18 +++++++-----------
> > > 1 file changed, 7 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> > > index 79d14af..322e57b 100644
> > > --- a/drivers/dma/sh/rcar-dmac.c
> > > +++ b/drivers/dma/sh/rcar-dmac.c
> > > @@ -1,14 +1,10 @@
> > > -/*
> > > - * Renesas R-Car Gen2 DMA Controller Driver
> > > - *
> > > - * Copyright (C) 2014 Renesas Electronics Inc.
> > > - *
> > > - * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > - *
> > > - * This is free software; you can redistribute it and/or modify
> > > - * it under the terms of version 2 of the GNU General Public License as
> > > - * published by the Free Software Foundation.
> > > - */
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +//
> > > +// Renesas R-Car Gen2 DMA Controller Driver
> > > +//
> > > +// Copyright (C) 2014 Renesas Electronics Inc.
> > > +//
> > > +// Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > I think the preferred comment style, accordingly to what other drivers do,
> > is
> >
> > // SPDX-License-Identifier: GPL-2.0
> > /*
> >
> > * Renesas R-Car Gen2 DMA Controller Driver
> > *
> > * Copyright (C) 2014 Renesas Electronics Inc.
> > *
> > * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > */
>
> And Linus said this https://lkml.org/lkml/2017/11/25/133
>
> So lets keep C99 style as Morimoto-San proposed.
>
> And high time, this should be documented :)
As mentioned before, while I certainly prefer the traditional C-style
comments, I ultimately let driver authors decide. What matters most in my
opinion is consistency, mixing styles in the same driver just makes the code
harder to read.
What matters in the end is how easy reading the code will be, and until the
majority of kernel developers get used to the C++ comment style, no matter
what Linus' personal preference is, // will be an annoyance.
^ permalink raw reply [flat|nested] 5+ messages in thread
* dmaengine: rcar-dmac: convert to SPDX identifiers
@ 2018-07-03 6:38 Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2018-07-03 6:38 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Kuninori Morimoto, Geert Uytterhoeven, Dan Williams, Magnus Damm,
Linux-Renesas, Kieran Bingham, Geert Uytterhoeven, dmaengine,
Hiroki Negishi
Hi Laurent,
On 03-07-18, 09:25, Laurent Pinchart wrote:
> On Tuesday, 3 July 2018 09:20:08 EEST Vinod wrote:
> > On 03-07-18, 08:49, Laurent Pinchart wrote:
> > > Hi Morimoto-san,
> > >
> > > Thank you for the patch.
> > >
> > > On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote:
> > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > A commit message would be nice :-)
> > >
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > ---
> > > >
> > > > drivers/dma/sh/rcar-dmac.c | 18 +++++++-----------
> > > > 1 file changed, 7 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> > > > index 79d14af..322e57b 100644
> > > > --- a/drivers/dma/sh/rcar-dmac.c
> > > > +++ b/drivers/dma/sh/rcar-dmac.c
> > > > @@ -1,14 +1,10 @@
> > > > -/*
> > > > - * Renesas R-Car Gen2 DMA Controller Driver
> > > > - *
> > > > - * Copyright (C) 2014 Renesas Electronics Inc.
> > > > - *
> > > > - * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > - *
> > > > - * This is free software; you can redistribute it and/or modify
> > > > - * it under the terms of version 2 of the GNU General Public License as
> > > > - * published by the Free Software Foundation.
> > > > - */
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > > +//
> > > > +// Renesas R-Car Gen2 DMA Controller Driver
> > > > +//
> > > > +// Copyright (C) 2014 Renesas Electronics Inc.
> > > > +//
> > > > +// Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > I think the preferred comment style, accordingly to what other drivers do,
> > > is
> > >
> > > // SPDX-License-Identifier: GPL-2.0
> > > /*
> > >
> > > * Renesas R-Car Gen2 DMA Controller Driver
> > > *
> > > * Copyright (C) 2014 Renesas Electronics Inc.
> > > *
> > > * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > */
> >
> > And Linus said this https://lkml.org/lkml/2017/11/25/133
> >
> > So lets keep C99 style as Morimoto-San proposed.
> >
> > And high time, this should be documented :)
>
> As mentioned before, while I certainly prefer the traditional C-style
> comments, I ultimately let driver authors decide. What matters most in my
> opinion is consistency, mixing styles in the same driver just makes the code
> harder to read.
>
> What matters in the end is how easy reading the code will be, and until the
> majority of kernel developers get used to the C++ comment style, no matter
> what Linus' personal preference is, // will be an annoyance.
Agreed, honestly this (style changes) has been unnecessary noise with no value add.
Sticking to one style would help and better to focus on real issues would be my take :)
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* dmaengine: rcar-dmac: convert to SPDX identifiers
@ 2018-07-03 6:20 Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2018-07-03 6:20 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Kuninori Morimoto, Geert Uytterhoeven, Dan Williams, Magnus Damm,
Linux-Renesas, Kieran Bingham, Geert Uytterhoeven, dmaengine,
Hiroki Negishi
On 03-07-18, 08:49, Laurent Pinchart wrote:
> Hi Morimoto-san,
>
> Thank you for the patch.
>
> On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote:
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> A commit message would be nice :-)
>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > drivers/dma/sh/rcar-dmac.c | 18 +++++++-----------
> > 1 file changed, 7 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> > index 79d14af..322e57b 100644
> > --- a/drivers/dma/sh/rcar-dmac.c
> > +++ b/drivers/dma/sh/rcar-dmac.c
> > @@ -1,14 +1,10 @@
> > -/*
> > - * Renesas R-Car Gen2 DMA Controller Driver
> > - *
> > - * Copyright (C) 2014 Renesas Electronics Inc.
> > - *
> > - * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > - *
> > - * This is free software; you can redistribute it and/or modify
> > - * it under the terms of version 2 of the GNU General Public License as
> > - * published by the Free Software Foundation.
> > - */
> > +// SPDX-License-Identifier: GPL-2.0
> > +//
> > +// Renesas R-Car Gen2 DMA Controller Driver
> > +//
> > +// Copyright (C) 2014 Renesas Electronics Inc.
> > +//
> > +// Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I think the preferred comment style, accordingly to what other drivers do, is
>
> // SPDX-License-Identifier: GPL-2.0
> /*
> * Renesas R-Car Gen2 DMA Controller Driver
> *
> * Copyright (C) 2014 Renesas Electronics Inc.
> *
> * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> */
And Linus said this https://lkml.org/lkml/2017/11/25/133
So lets keep C99 style as Morimoto-San proposed.
And high time, this should be documented :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* dmaengine: rcar-dmac: convert to SPDX identifiers
@ 2018-07-03 5:49 Laurent Pinchart
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2018-07-03 5:49 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Vinod, Geert Uytterhoeven, Dan Williams, Magnus Damm,
Linux-Renesas, Kieran Bingham, Geert Uytterhoeven, dmaengine,
Hiroki Negishi
Hi Morimoto-san,
Thank you for the patch.
On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
A commit message would be nice :-)
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> drivers/dma/sh/rcar-dmac.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index 79d14af..322e57b 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -1,14 +1,10 @@
> -/*
> - * Renesas R-Car Gen2 DMA Controller Driver
> - *
> - * Copyright (C) 2014 Renesas Electronics Inc.
> - *
> - * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> - *
> - * This is free software; you can redistribute it and/or modify
> - * it under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// Renesas R-Car Gen2 DMA Controller Driver
> +//
> +// Copyright (C) 2014 Renesas Electronics Inc.
> +//
> +// Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I think the preferred comment style, accordingly to what other drivers do, is
// SPDX-License-Identifier: GPL-2.0
/*
* Renesas R-Car Gen2 DMA Controller Driver
*
* Copyright (C) 2014 Renesas Electronics Inc.
*
* Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
*/
Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* dmaengine: rcar-dmac: convert to SPDX identifiers
@ 2018-07-03 0:29 Kuninori Morimoto
0 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2018-07-03 0:29 UTC (permalink / raw)
To: Vinod
Cc: Geert Uytterhoeven, Dan Williams, Magnus Damm, Linux-Renesas,
Laurent Pinchart, Kieran Bingham, Geert Uytterhoeven, dmaengine,
Hiroki Negishi
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/dma/sh/rcar-dmac.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index 79d14af..322e57b 100644
--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -1,14 +1,10 @@
-/*
- * Renesas R-Car Gen2 DMA Controller Driver
- *
- * Copyright (C) 2014 Renesas Electronics Inc.
- *
- * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
- *
- * This is free software; you can redistribute it and/or modify
- * it under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- */
+// SPDX-License-Identifier: GPL-2.0
+//
+// Renesas R-Car Gen2 DMA Controller Driver
+//
+// Copyright (C) 2014 Renesas Electronics Inc.
+//
+// Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
#include <linux/delay.h>
#include <linux/dma-mapping.h>
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-03 6:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 6:25 dmaengine: rcar-dmac: convert to SPDX identifiers Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2018-07-03 6:38 Vinod Koul
2018-07-03 6:20 Vinod Koul
2018-07-03 5:49 Laurent Pinchart
2018-07-03 0:29 Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).