From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx-relay50-hz3.antispameurope.com (mx-relay50-hz3.antispameurope.com [94.100.134.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB4E717332C for ; Mon, 13 Oct 2025 14:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=94.100.134.239 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760365107; cv=pass; b=CWiaDw7v7jq6wFHPofTpS3ssor6JXgrilDi9aYuRwrv5s0Y8BxI+RbbS2K0TMk0b6r9x4RX3vGk9RBwbsAtzb6rMovSpO76mC3nz7YV0+irK6yp80+HJW4aZhxdXrljlWp30VdG1JRotBEzpsTt+yC8gMpTfAWowkUmroDUKp34= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760365107; c=relaxed/simple; bh=5ufhlfvjUyDT/EvvG3BasNRmVjK3W5wb5ZuUARDs7LM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YxjNBq+OWhCj173c+FOpXU0RVD4u54Q3uVEWVkw5P5/Hy788BCwVoAgPUehVK+N/hIXLQ5WjI+25e4pGFgFEhWQ/MXW7PrrSbFGeQhytgfotN3kLSmWETDz6xtFNBRYNUxpKUIfM5Tii+pnszn7tK0S5pkjv//cRNUtnDd/jGfo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=VQXi0aNl; arc=pass smtp.client-ip=94.100.134.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="VQXi0aNl" ARC-Authentication-Results: i=1; mx-gate50-hz3.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=hmail-p-smtp01-out04-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=vyXrVVygqMhn5Bif81+tF99rIVbrn5Q3omrjq9+Xlzs=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1760365085; b=kmD5NeR9JEd6XJCN2yLSmSUglmYyF73ns03hs6HaJSzX1T9ZPHyJdLVCTBBVO6huyLqwRl2V E78nXD+bPjYaRX2ath54kctg/vapWXsispuPK3yfjqiSpQqqIMhEBCA3p5NEae/D20Et+yv2PDQ Voo3Lm3Zz3DM9bHVWIlphQ+TK2F5/002PbfLEX8B0E5XiKY1B37hP5nniX6wB+rFs09QqoPyHW5 Q+sJE7VlUBCYozVRqwi+63u2LIOqQrGloXFCP1A8znh6d/9ZFmlgQ9dvHOvWqKIOM3uiqC/AE6k 6My2WHOJsEQgKdtO6j3rz6lgBaAMcA4D96h1szLTJzxVg== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1760365085; b=cjXbNIQhTYb2sXpQJyKuH/YFi0Vx8YLTEhtvejIbVX6r4mH696FPa5Ad7yYckDak9uGOr6Hq Mok3fWOKExXRrunAWTrLDzQElKwOTLkk0XfAIlNnXzCcXHc9nXpdVoZXyny+0r9E87Iy3L83Tn5 VhciLVrI6snMw56/OA2qETZoVfwxCcqFtA0n9ewYhNIriJGuD05WVXW+FFG6XkP+pcbXq9xA6XZ 7PtQYu8zvF+Cw4S+7Fq3nbvXeCA9LNEjigwW+r+QPKSKhpsbxJk1XW3n6B2IfEleIcS759oAALU Q3cYpU7W+/XBeXTRplBZ6EsMfyB8rGW2v0E2LBwL6p8Xw== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay50-hz3.antispameurope.com; Mon, 13 Oct 2025 16:18:05 +0200 Received: from steina-w.localnet (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: alexander.stein@ew.tq-group.com) by hmail-p-smtp01-out04-hz1.hornetsecurity.com (Postfix) with ESMTPSA id 43C43220CFE; Mon, 13 Oct 2025 16:17:57 +0200 (CEST) From: Alexander Stein To: Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Vinod Koul , Michal Simek , anthony@amarulasolutions.com Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anthony Brandon , Radhey Shyam Pandey Subject: Re: [PATCH v4] dmaengine: xilinx: xdma: Fix regmap max_register Date: Mon, 13 Oct 2025 16:17:56 +0200 Message-ID: <2389383.ElGaqSPkdT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20250903-xdma-max-reg-v4-1-894721175025@amarulasolutions.com> References: <20250903-xdma-max-reg-v4-1-894721175025@amarulasolutions.com> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-cloud-security-sender:alexander.stein@ew.tq-group.com X-cloud-security-recipient:dmaengine@vger.kernel.org X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: alexander.stein@ew.tq-group.com X-cloud-security-Mailarchivtype:outbound X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay50-hz3.antispameurope.com with 4clfZY5vRpz2nH1K X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest:ce6e0c546d8b9a92df42d712c97e6124 X-cloud-security:scantime:2.191 DKIM-Signature: a=rsa-sha256; bh=vyXrVVygqMhn5Bif81+tF99rIVbrn5Q3omrjq9+Xlzs=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1760365085; v=1; b=VQXi0aNl6QJhkWk4JUCejsZVdYB9RfREgtRZmUYmM4K/QCydYtH3OUelqGcxb7KEDM1yHqzo d+woBB0HNiBzMrHeGHw7XegtRHCy0U0B+O4TIrUS+4GzIY3/gSgugHpKYVBsld+gkKraK9ekd+2 Yjh3h4tY58zZIEDsh1Nd4KDlPKJgc+0MsRwNEWYP46tl4eso9q2TC8hiMuKT+gcGfifC9/bD5y+ 80sSTVIlVWMaWC3xc2pbG9UMQZCC9WgYTDacAeTa7wTFo0p2ndA+eSsk/o/Ml57I+HU04gmKkuV fF/PxaEnwHG8uvQxQ6y1i7W74AhmJhf5AhS2feOGhdk6A== Am Mittwoch, 3. September 2025, 10:56:13 CEST schrieb Anthony Brandon via B4 Relay: > From: Anthony Brandon > > The max_register field is assigned the size of the register memory > region instead of the offset of the last register. > The result is that reading from the regmap via debugfs can cause > a segmentation fault: > > tail /sys/kernel/debug/regmap/xdma.1.auto/registers > Unable to handle kernel paging request at virtual address ffff800082f70000 > Mem abort info: > ESR = 0x0000000096000007 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x07: level 3 translation fault > [...] > Call trace: > regmap_mmio_read32le+0x10/0x30 > _regmap_bus_reg_read+0x74/0xc0 > _regmap_read+0x68/0x198 > regmap_read+0x54/0x88 > regmap_read_debugfs+0x140/0x380 > regmap_map_read_file+0x30/0x48 > full_proxy_read+0x68/0xc8 > vfs_read+0xcc/0x310 > ksys_read+0x7c/0x120 > __arm64_sys_read+0x24/0x40 > invoke_syscall.constprop.0+0x64/0x108 > do_el0_svc+0xb0/0xd8 > el0_svc+0x38/0x130 > el0t_64_sync_handler+0x120/0x138 > el0t_64_sync+0x194/0x198 > Code: aa1e03e9 d503201f f9400000 8b214000 (b9400000) > ---[ end trace 0000000000000000 ]--- > note: tail[1217] exited with irqs disabled > note: tail[1217] exited with preempt_count 1 > Segmentation fault > > Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver") > Signed-off-by: Anthony Brandon > Reviewed-by: Lizhi Hou > Reviewed-by: Radhey Shyam Pandey Reviewed-by: Alexander Stein > --- > Changes in v4: > - Reorder Reviewed-by > - Link to v3: https://lore.kernel.org/r/20250902-xdma-max-reg-v3-1-5fa37b8d2b15@amarulasolutions.com > > Changes in v3: > - Add Fixes tag > - Link to v2: https://lore.kernel.org/r/20250901-xdma-max-reg-v2-1-fa3723a718cd@amarulasolutions.com > > Changes in v2: > - Define new constant XDMA_MAX_REG_OFFSET and use that. > - Link to v1: https://lore.kernel.org/r/20250901-xdma-max-reg-v1-1-b6a04561edb1@amarulasolutions.com > --- > drivers/dma/xilinx/xdma-regs.h | 1 + > drivers/dma/xilinx/xdma.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/xdma-regs.h b/drivers/dma/xilinx/xdma-regs.h > index 6ad08878e93862b770febb71b8bc85e66813428e..70bca92621aa41b0367d1e236b3e276344a26320 100644 > --- a/drivers/dma/xilinx/xdma-regs.h > +++ b/drivers/dma/xilinx/xdma-regs.h > @@ -9,6 +9,7 @@ > > /* The length of register space exposed to host */ > #define XDMA_REG_SPACE_LEN 65536 > +#define XDMA_MAX_REG_OFFSET (XDMA_REG_SPACE_LEN - 4) > > /* > * maximum number of DMA channels for each direction: > diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c > index 0d88b1a670e142dac90d09c515809faa2476a816..5ecf8223c112e468c79ce635398ba393a535b9e0 100644 > --- a/drivers/dma/xilinx/xdma.c > +++ b/drivers/dma/xilinx/xdma.c > @@ -38,7 +38,7 @@ static const struct regmap_config xdma_regmap_config = { > .reg_bits = 32, > .val_bits = 32, > .reg_stride = 4, > - .max_register = XDMA_REG_SPACE_LEN, > + .max_register = XDMA_MAX_REG_OFFSET, > }; > > /** > > --- > base-commit: b320789d6883cc00ac78ce83bccbfe7ed58afcf0 > change-id: 20250901-xdma-max-reg-1649c6459358 > > Best regards, >