DMA Engine development
 help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com>
To: Chen Ni <nichen@iscas.ac.cn>, <dave.jiang@intel.com>, <vkoul@kernel.org>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: idxd: Convert comma to semicolon
Date: Wed, 10 Jul 2024 16:39:12 -0700	[thread overview]
Message-ID: <24079077-ada9-0150-e542-0002ae3e9b61@intel.com> (raw)
In-Reply-To: <20240710030725.1960882-1-nichen@iscas.ac.cn>



On 7/9/24 20:07, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

better to add "for more readability."

Otherwise, there is no issue with the commas.

> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

> ---
>   drivers/dma/idxd/perfmon.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/perfmon.c b/drivers/dma/idxd/perfmon.c
> index 5e94247e1ea7..e596ea60ed3c 100644
> --- a/drivers/dma/idxd/perfmon.c
> +++ b/drivers/dma/idxd/perfmon.c
> @@ -480,8 +480,8 @@ static void idxd_pmu_init(struct idxd_pmu *idxd_pmu)
>   	idxd_pmu->pmu.attr_groups	= perfmon_attr_groups;
>   	idxd_pmu->pmu.task_ctx_nr	= perf_invalid_context;
>   	idxd_pmu->pmu.event_init	= perfmon_pmu_event_init;
> -	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable,
> -	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable,
> +	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable;
> +	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable;
>   	idxd_pmu->pmu.add		= perfmon_pmu_event_add;
>   	idxd_pmu->pmu.del		= perfmon_pmu_event_del;
>   	idxd_pmu->pmu.start		= perfmon_pmu_event_start;

Thanks.

-Fenghua

      parent reply	other threads:[~2024-07-10 23:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10  3:07 [PATCH] dmaengine: idxd: Convert comma to semicolon Chen Ni
2024-07-10 15:38 ` Dave Jiang
2024-07-10 23:39 ` Fenghua Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24079077-ada9-0150-e542-0002ae3e9b61@intel.com \
    --to=fenghua.yu@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox