From: Christian Lamparter <chunkeey@gmail.com>
To: Vinod <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: dmaengine: ppc4xx: fix off-by-one build failure
Date: Tue, 16 Oct 2018 22:28:46 +0200 [thread overview]
Message-ID: <2882273.JdLy0MJ3tD@debian64> (raw)
On Tuesday, October 16, 2018 4:40:27 PM CEST Vinod wrote:
> On 14-10-18, 23:28, Christian Lamparter wrote:
> > There are two poly_store, but one should have been poly_show.
> >
> > |adma.c:4382:16: error: conflicting types for 'poly_store'
> > | static ssize_t poly_store(struct device_driver *dev, const char *buf,
> > | ^~~~~~~~~~
> > |adma.c:4363:16: note: previous definition of 'poly_store' was here
> > | static ssize_t poly_store(struct device_driver *dev, char *buf)
> > | ^~~~~~~~~~
>
> How come no one noticed till now :(
Well, I don't know if this driver works or not. I tried to evaluate
if this driver could be modified to fit the PLB4DMA of the APM82181.
But sadly this was not the case because the APM82181 and PPC460EX
have a new design. So, I just happend to find this little bug, no
idea if there's more bit-rot.
Regards,
Christian
next reply other threads:[~2018-10-16 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 20:28 Christian Lamparter [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-16 14:40 dmaengine: ppc4xx: fix off-by-one build failure Vinod Koul
2018-10-14 21:28 Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2882273.JdLy0MJ3tD@debian64 \
--to=chunkeey@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).