From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Arnd Bergmann <arnd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Dan Williams <dan.j.williams@intel.com>,
Yu Kuai <yukuai3@huawei.com>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: ti: k3-udma: fix -Wenum-conversion warning
Date: Tue, 27 Oct 2020 09:02:18 +0200 [thread overview]
Message-ID: <2bf8a179-9dad-97b9-2295-31d27eefdbb7@ti.com> (raw)
In-Reply-To: <20201026160123.3704531-1-arnd@kernel.org>
On 26/10/2020 18.01, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc warns about a mismatch argument type when passing
> 'false' into a function that expects an enum:
Strange enough, but my gcc does not warn me (Gentoo 10.2.0-r2 p3).
> drivers/dma/ti/k3-udma-private.c: In function 'xudma_tchan_get':
> drivers/dma/ti/k3-udma-private.c:86:34: warning: implicit conversion from 'enum <anonymous>' to 'enum udma_tp_level' [-Wenum-conversion]
> 86 | return __udma_reserve_##res(ud, false, id); \
> | ^~~~~
> drivers/dma/ti/k3-udma-private.c:95:1: note: in expansion of macro 'XUDMA_GET_PUT_RESOURCE'
> 95 | XUDMA_GET_PUT_RESOURCE(tchan);
> | ^~~~~~~~~~~~~~~~~~~~~~
But this is valid. The Throughput Levels got expanded with j721e from 2
to three and I failed to update this.
> In this case, false has the same numerical value as
> UDMA_TP_NORMAL, so passing that is most likely the correct
> way to avoid the warning without changing the behavior.
Yes, that's correct, thanks for fixing it!
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Fixes: d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/dma/ti/k3-udma-private.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ti/k3-udma-private.c b/drivers/dma/ti/k3-udma-private.c
> index aa24e554f7b4..8563a392f30b 100644
> --- a/drivers/dma/ti/k3-udma-private.c
> +++ b/drivers/dma/ti/k3-udma-private.c
> @@ -83,7 +83,7 @@ EXPORT_SYMBOL(xudma_rflow_is_gp);
> #define XUDMA_GET_PUT_RESOURCE(res) \
> struct udma_##res *xudma_##res##_get(struct udma_dev *ud, int id) \
> { \
> - return __udma_reserve_##res(ud, false, id); \
> + return __udma_reserve_##res(ud, UDMA_TP_NORMAL, id); \
> } \
> EXPORT_SYMBOL(xudma_##res##_get); \
> \
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-10-27 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 16:01 [PATCH] dmaengine: ti: k3-udma: fix -Wenum-conversion warning Arnd Bergmann
2020-10-27 7:02 ` Peter Ujfalusi [this message]
2020-10-28 5:52 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bf8a179-9dad-97b9-2295-31d27eefdbb7@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox