From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7E37E792 for ; Fri, 25 Oct 2024 18:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729880231; cv=none; b=bY90EGQSnr0uC/3D05AIZ8vFgOxXhqrSNyuaxIkoqaDl4dken5NosirnbWJIZg5g0CFdkDI4M3fOtfkMfa7z9aGdxiGhnXXGfpRUnMCUKn7KjVBK5NKcCvrJ4u15FaUdv2crlebL6xIsPDo5WMRPpLglsEo0eiGj1leFJIbv5oY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729880231; c=relaxed/simple; bh=CLS/iIPGDJE60av5udYuI/xjQzJ7unxdzp+4M0UFoyU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZRy8/VdgnUqNoKQYlAnfMDuV+uhqbiUAYEse/yxfT5zmbzhh8nAeTBrj7HBb74ccsjFmSiSg0rrULRgc2oJo59bsvAtyM+TQjPSKzg3Ivq1yzcgWskYbTbocp3D85XsW5TGb9BBqaoD5v5FCbLk+d9Nwg4Yi/yyU7Ama/jriARk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZABtq7Sz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZABtq7Sz" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49PG3Igm020204 for ; Fri, 25 Oct 2024 18:17:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FSJlO0TfoNk3Ycf8qBZrvMLnGxcnluZFEUKQHGyj/j8=; b=ZABtq7SzlRm1k9EV uprK+tTiR6xL0H49FF6vgr4ymQ6KhebJC4QgT1Vp/WBkutonRsik3ozfKeVpEPw/ lS+QZGBx0M1NSIB3noFVYletL3I1eGj75kXptq63yr1kCytujaos+BlGK56i7u1O fRMN2W6KKXukNjmYNHfcFsaVdrl6ybPZUnaEslp/qtu1SFXNgaJOTH74M7azW600 aNKSY7Pty/c7XIaeyCFC8xUBdMdhdvY0Q6pKVrN4ptyhCUqkEF8mBTFAjBBVml0W dVlJTWAi6xK+IItBi5uH/t71j3dSVIV0bJP/9qgqbtpb03B1NigNnBcNuB21UMqV GEzVWA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42g6y91w1y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Oct 2024 18:17:09 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6cbf4770c18so6835986d6.2 for ; Fri, 25 Oct 2024 11:17:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729880227; x=1730485027; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FSJlO0TfoNk3Ycf8qBZrvMLnGxcnluZFEUKQHGyj/j8=; b=tDxNavof52nzit0zY1IPyHD8h1H/a4Fe9eOfDUOMrKYjQQZzSzoR801NAity4evxtl mWNXtbRMhHxDS+A5qUqxR99jZaAgYlTbqOX7bCtjvAZezaM93jzNkmg0QBf1C+WE4sx9 cIvETABGmX8FDWZKUpo/n8RUMxSlSIqCaVocoDAfQAI1wtmx5xWPlFBGEkEpW1JMTvLY KA45LHW+cJJq+vXnPSNgsPHthLEgMOMFh/qC38Ks05FvMJYakjw1Rln3LWjR/ITsW1tF XY423OZ5IFZdnq9ryWhlo6ntuGZntG1XD7xe3zORfHcmQka6OcMqFgCqQllqkXh5Bnln Z15w== X-Forwarded-Encrypted: i=1; AJvYcCWkL2gvqwD4biOSGBNfvyTovDRvhsjF7xM11PsyEHcX6rU3dC7lw2CTza+j0OeegW4z34RRWErdl/g=@vger.kernel.org X-Gm-Message-State: AOJu0YxrSQe0s03QTQqjk46UH0VgIdKI+nIr2W3fjFYyE5PVjR0jLqHz g2QFGYU0v5A74G/E4RJXIeHGzYaZsY8DS8FtWr0xPoGl/1i372hqzYG6XzDysqUpwm1TwLPYzwE zLMaQSmvYYgAJd/84mM4pBHkHKm5eUPU9E7v6oQG8gN01+jfZ9UJGzwOc7oc= X-Received: by 2002:a05:6214:d45:b0:6cb:c6da:5fe3 with SMTP id 6a1803df08f44-6d18567a31cmr2484936d6.1.1729880227489; Fri, 25 Oct 2024 11:17:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8+KqX0qE5evxjRaHUn806H0k1eImIZc7s/QW9fbWd1DSEaL/b0S3oNWR+qh1FZINISLpdqQ== X-Received: by 2002:a05:6214:d45:b0:6cb:c6da:5fe3 with SMTP id 6a1803df08f44-6d18567a31cmr2484616d6.1.1729880227230; Fri, 25 Oct 2024 11:17:07 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b3a081d59sm95061466b.189.2024.10.25.11.17.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Oct 2024 11:17:06 -0700 (PDT) Message-ID: <333948f0-44ff-424a-8d38-5fba719d2aeb@oss.qualcomm.com> Date: Fri, 25 Oct 2024 20:17:03 +0200 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/5] dmaengine: qcom: gpi: Add provision to support TRE size as the fourth argument of dma-cells property To: Jyothi Kumar Seerapu , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andi Shyti , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com References: <20241015120750.21217-1-quic_jseerapu@quicinc.com> <20241015120750.21217-4-quic_jseerapu@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241015120750.21217-4-quic_jseerapu@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: merV3EcNAvFCfXa3WWJpdhTqGTYPhYq0 X-Proofpoint-ORIG-GUID: merV3EcNAvFCfXa3WWJpdhTqGTYPhYq0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 clxscore=1011 lowpriorityscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410250140 On 15.10.2024 2:07 PM, Jyothi Kumar Seerapu wrote: > The current GPI driver hardcodes the channel TRE (Transfer Ring Element) > size to 64. For scenarios requiring high performance with multiple > messages in a transfer, use Block Event Interrupt (BEI). > This method triggers interrupt after specific message transfers and > the last message transfer, effectively reducing the number of interrupts. > For multiple transfers utilizing BEI, a channel TRE size of 64 is > insufficient and may lead to transfer failures, indicated by errors > related to unavailable memory space. > > Added provision to modify the channel TRE size via the device tree. > The Default channel TRE size is set to 64, but this value can update > in the device tree which will then be parsed by the GPI driver. > > Signed-off-by: Jyothi Kumar Seerapu > --- 1. Is the total memory pool for these shared? 2. Is there any scenario where we want TRE size to be lower and not higher? Are there any drawbacks to always keeping them at SOME_MAX_VALUE? 3. Is this something we should configure at boot time (in firmware)? Perhaps this could be decided based on client device settings (which may or may not require adding some field in the i2c framework) Konrad