From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFC862153D3 for ; Wed, 30 Jul 2025 22:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753914793; cv=none; b=rw1w92wzC5gKXwis3/0CYd2J/JdD4wO57U87AsnTn3a3vvxj1rjqKCdyc4qtJiFQiydkR2Rhsn0sUhB4qmCv5h86CkezGPyAHYXbIEhOSfVfq1MMZOq6LRbCUzQYZn+x79z3B0AR34rsbD5znYs7LnjJ8q8dGHJ3u3aE9ihTdkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753914793; c=relaxed/simple; bh=XD8mWT7+uwBdZy8KdwpfcJE94eBSheB6SpO3Eck7/ec=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rE3xxmfnE2aQonGzFBA3/vfUYm78qGco9U9sTEnPa3po1KCggV1MwfUx70/fM9tbMRgGZ9bdTn0dSNvLZB/ufJTE7qnAqwwUQXqD9kkO5avZ7JNAsrD8p9uy/V24frIkVcCPPKSFFt2b9s+Gu82l4ws4DqeYfVFcFKZUmAw0v5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a3V/EC2z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a3V/EC2z" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56UCbBun028218 for ; Wed, 30 Jul 2025 22:33:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KIB9+SMIMAIs+ix0aXzyrQiRdkqV0NUTde9TQd6wMzQ=; b=a3V/EC2z4ipyNlKh gqW7ffq3BvDUgYszA1pR7+aguXmkDMKR1xggTDN6Ox9S0p1JpSYg1LR0Y3NQO50F cvZY2ft2pW0qFV/IpFJHabsA9Y2WbIzDF19K23efnVSeyXlMD5YVUC9JeCDN3PwC ub3AU3ws9uOW7ojAv5hfV4pIT/IWYhi8pHy1RNwuX2RT48anj5+MluXB5u8zsqcF ZqjuKBYasKn8Ubwb7ThH8qxGLsrSz85Pc2gukXb3BZxWy24COmDWsIJ6k8sqiBUC srB/A4CelybrjPyIHWUucIYUoEIW5ZHfzJR6js8+hCvgVr7bGFT5g+IhjxwlKxjz XMhEkA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484nyu5up9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 30 Jul 2025 22:33:05 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4aba4196db7so887471cf.0 for ; Wed, 30 Jul 2025 15:33:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753914784; x=1754519584; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KIB9+SMIMAIs+ix0aXzyrQiRdkqV0NUTde9TQd6wMzQ=; b=f+mIn6CyLf75wbu6246R7XbqXfj189O6mLAVB1yY7U6w+qVrMD/fmzS0Hqa4zCJ+P+ VyCGADvWhIZIbewf8GmVZnFa4F0Io/YZMtc3xMc5mXhhS7QGFbzByN/jKCekAKK4N/fJ jFwx9tfotP+Ir/BFqLVVCT590sVXoYRAEBsH46C2kaAjmdm5Ag8Lyky3KLQoAhmsldeU 8zOK1TzstNDMPG6JjQZV/t0cqqcOPD2mRavNXZzpsbAjedwv7ZwX1YSusXZNr1BoTkmr SvtuFhAvRgtcQHbGU+OFSMZUv4ysm1zvBJV7jPHI68G18+Sq4dn7Se/SLt23Tzc41qvL iQVQ== X-Forwarded-Encrypted: i=1; AJvYcCXtuYyr5S4KZZazjz+U8rMG67RjQBi1tuKVs1HuIiV32yQikQEs/uuHIbsIXT9ErEMmeb7nL4vkfI0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy54op3ezJLHkQNToDqvutRl6Cb5W7HtkR73nQ0ml8LfL12R2ov kaDc/KQT7WbSp6R+c6N+zR2Mg2O1csWQoqWefXqNLaiQ3t8zhP+JKdubunv1WsauAqaZXO7wcOR MU+/AFCqoOdgsMCo1+e8f2OpO1sm4wcecSkgYOvpt6Y8jW2lSYg/q0x1MZesipcA= X-Gm-Gg: ASbGncveB2AevZ+YTnsNVtKmMe049h5yUKqvElfF/L/Y/xNekdbxltknW7cks6JLQRO oQ0Jbzk6PNAcs/mbd75Dq2PobJ5MWhkC0EAKqjWEid1TqtJMdv3KigTg8qTOb1ryL7uwijcOf6A 7XmSPPRLI1ZFDiB/WruIMAiq9gomg5xknZBgAP7m84PfRIfN70XjGzg7rYirSkTI3cS9Cxbu2Fa hh+9pFSnm+T6NPJancwreuGV6MIBIEyvZxkWRG+bCQY1W5QVhvgKW3uBSZx5N8M54D4HsWUaTWr GyJBBUnD7oltXP0MbM+Yl9QqpXImlcOYxI6RkwjtD964ULXXT89pAaZDggl98xpDrs/S+PXWW8E ba7cZNd+wkJz6gGEQzA== X-Received: by 2002:ac8:5709:0:b0:4a9:a320:f528 with SMTP id d75a77b69052e-4aedb93aec3mr46217991cf.3.1753914783918; Wed, 30 Jul 2025 15:33:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzJ1DWPgTqRJxs6el7saUaAs1Unr4la0oOLT0iT+JU7OrzOzfJloiF82fDLMEGg79NNIYk0w== X-Received: by 2002:ac8:5709:0:b0:4a9:a320:f528 with SMTP id d75a77b69052e-4aedb93aec3mr46216811cf.3.1753914781653; Wed, 30 Jul 2025 15:33:01 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a1e82b0sm8695266b.87.2025.07.30.15.32.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 15:33:00 -0700 (PDT) Message-ID: <36f3ef2d-fd46-492a-87e6-3eb70467859d@oss.qualcomm.com> Date: Thu, 31 Jul 2025 00:32:58 +0200 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sc8280xp: Describe GPI DMA controller nodes To: Pengyu Luo , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250617090032.1487382-1-mitltlatltl@gmail.com> <20250617090032.1487382-3-mitltlatltl@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250617090032.1487382-3-mitltlatltl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: dfZ3sfmipJ6DBt3ZruODrPPH5nCuYFWL X-Proofpoint-ORIG-GUID: dfZ3sfmipJ6DBt3ZruODrPPH5nCuYFWL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzMwMDE2NCBTYWx0ZWRfX9gkoBkRIhSZF f2ZFEm1mYzDN7KdAIKc+BjBmu810d72baHGkAkFfBrnaBoP7MmImxey5sf7jCmFCvNA3Tg99/sG gezqDQGKZnh4Q0yrD06f6+P6/qfiVGmmmkYVv5WFw8lha/XBHUiyyeEJ88xeFLQ193fS9ovOIDE W+fXvJf6RJsmYDFpShBtH05VCWqIQF1+h8o/o84JcigFHyvQCckZL3V9i8tsXmcV2u53uUO0dtj Kc7HubhO9eiq/eSJVtgbe888c4h0VJ6V01Y7/OjQ6df4h86a9cgI92GydUtwKejJaCb3BsGhxEN ZEAudsxR6CYc2c+rByQ4LkVUPNajDbUjLcPPXJT7giYYhUTnuh5Tso0vMuP2T4mEoazJL42sWXZ QraTkHL0gS+0Jbj2RVruAs2IjtH4w1RFul3lkPH7cRRiVJn5S7vWOSumbv/4SnSt4o2SEhTT X-Authority-Analysis: v=2.4 cv=CLoqXQrD c=1 sm=1 tr=0 ts=688a9da1 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=pGLkceISAAAA:8 a=3m9cAMs9dPIHispIsJUA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-30_06,2025-07-30_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=974 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 clxscore=1015 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507300164 On 6/17/25 11:00 AM, Pengyu Luo wrote: > SPI on SC8280XP requires DMA (GSI) mode to function properly. Without > it, SPI controllers fall back to FIFO mode, which causes: > > [ 0.901296] geni_spi 898000.spi: error -ENODEV: Failed to get tx DMA ch > [ 0.901305] geni_spi 898000.spi: FIFO mode disabled, but couldn't get DMA, fall back to FIFO mode > ... > [ 45.605974] goodix-spi-hid spi0.0: SPI transfer timed out > [ 45.605988] geni_spi 898000.spi: Can't set CS when prev xfer running > [ 46.621555] spi_master spi0: failed to transfer one message from queue > [ 46.621568] spi_master spi0: noqueue transfer failed > [ 46.621577] goodix-spi-hid spi0.0: spi transfer error: -110 > [ 46.621585] goodix-spi-hid spi0.0: probe with driver goodix-spi-hid failed with error -110 > > Therefore, describe GPI DMA controller nodes for qup{0,1,2}, and > describe DMA channels for SPI and I2C, UART is excluded for now, as > it does not yet support this mode. > > Note that, since there is no public schematic, this is derived from > Windows drivers. The drivers do not expose any DMA channel mask > information, so all available channels are enabled. > > Signed-off-by: Pengyu Luo > --- [...] > + gpi_dma0: dma-controller@900000 { Double space before '{' > + compatible = "qcom,sc8280xp-gpi-dma", "qcom,sm6350-gpi-dma"; > + reg = <0 0x00900000 0 0x60000>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; The last entry is incorrect and superfluous, please remove You can also enable the gpi_dma nodes by default lgtm otherwise Konrad