DMA Engine development
 help / color / mirror / Atom feed
From: Scott Branden <scott.branden@broadcom.com>
To: Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org
Cc: Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>
Subject: [02/12] dmaengine: bcm2835: remove dma_slave_config direction usage
Date: Tue, 11 Sep 2018 14:11:19 -0700	[thread overview]
Message-ID: <3953c77b-17e7-5be7-f968-da3821043d50@broadcom.com> (raw)

On 18-09-11 01:35 AM, Vinod Koul wrote:
> dma_slave_config direction was marked as deprecated quite some
> time back, remove the usage from this driver so that the field
> can be removed
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> CC: Ray Jui <rjui@broadcom.com>
> CC: Scott Branden <sbranden@broadcom.com>
>
>   drivers/dma/bcm2835-dma.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 847f84a41a69..cad55ab80d41 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -778,14 +778,6 @@ static int bcm2835_dma_slave_config(struct dma_chan *chan,
>   {
>   	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
>   
> -	if ((cfg->direction == DMA_DEV_TO_MEM &&
> -	     cfg->src_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||
> -	    (cfg->direction == DMA_MEM_TO_DEV &&
> -	     cfg->dst_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||
> -	    !is_slave_direction(cfg->direction)) {
> -		return -EINVAL;
> -	}
> -
>   	c->cfg = *cfg;
>   
>   	return 0;

             reply	other threads:[~2018-09-11 21:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 21:11 Scott Branden [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-09-11  8:35 [02/12] dmaengine: bcm2835: remove dma_slave_config direction usage Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3953c77b-17e7-5be7-f968-da3821043d50@broadcom.com \
    --to=scott.branden@broadcom.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox