From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C21F1B253B; Mon, 9 Sep 2024 09:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725873505; cv=none; b=txRuRz1JjJHMrZibdYP0JRbanT1fk7U3sCrT0EC05vl4ikXGTkbtapYLOJN2Yta04JPvaSCS/U11qtuOfeR2zYn+zOyc4/ljerD8VbVPfL9t+XNu2uOFPvteL7hqCYWhy/l/ZbwRcrrWIM9hbiPjS5LhIn16Lzl/FUMVKr6Ffl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725873505; c=relaxed/simple; bh=bvfjSC5phQoKuCouGkBJTQXwhIYeaiEJfkF1aQTCjb4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=M1EXABbdXcPEHP7J2irOdf/43uqky70CmFAfOkhcK01mAqG5CqDOs+Pt/7F1mKxVbkeiDeoi0C8Cc7S2k9SUM5Zh7KIMtLZZr4D1pqAwykeHicbSfFTpeqdHWAHRH9GMdIgvgaqchMYrn2uJ/5iK3TafExb/3MEwiAcBjhO9fDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Pq9sWnfm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Pq9sWnfm" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 488Nm1Oh021078; Mon, 9 Sep 2024 09:18:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= L/IJrSHy7E4FooCJHAm7B+K/qE7+a22FjpwLDSTK1Oc=; b=Pq9sWnfmUITZXqz3 Ye4QsQ+bm4x4i+5JpJrfN4CXjtOE6b/e5HSx6JoX9Nd8l8/mEVb+K1QDo4MVMhPX N+ikxXhdi6G+etu5jNs5zWow//AvcOOV1W39t5K3voCJUORjiq70v8hUk7P8v+gL mrZNSmQQ8envru54tNdbq/VoOrshtFnmeD5c36FYSSKrNbqHLinza2RPTJALxqRv mNsFzQi8gK0ozuzvBOx2byIx5aNhOVdhGwG46hlzEjCqdsbnFij8zLdttuNoTRRp 4FeC2wQ3lkHqruwq0RSChVRsHq3mukme8wlZVA/qCg5nKTyFRPpadjVF3A2ZNL6R tBetZw== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41gy6p2afs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Sep 2024 09:18:13 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4899ICIm007772 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 9 Sep 2024 09:18:12 GMT Received: from [10.217.219.207] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 9 Sep 2024 02:18:07 -0700 Message-ID: <3bd27b6d-74b8-4f7b-b3eb-64682442bbda@quicinc.com> Date: Mon, 9 Sep 2024 14:48:04 +0530 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] i2c: i2c-qcom-geni: Enable i2c controller sharing between two subsystems To: , , , , , , , , , , , , , , , CC: References: <20240906191438.4104329-1-quic_msavaliy@quicinc.com> <20240906191438.4104329-5-quic_msavaliy@quicinc.com> Content-Language: en-US From: Mukesh Kumar Savaliya In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: -sJyNF0Pcpq-AtjnklkLCs46O_uGJGZ0 X-Proofpoint-GUID: -sJyNF0Pcpq-AtjnklkLCs46O_uGJGZ0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 mlxscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409090073 Hi Neil, On 9/9/2024 2:24 PM, neil.armstrong@linaro.org wrote: > Hi, > > On 06/09/2024 21:14, Mukesh Kumar Savaliya wrote: >> Add support to share I2C SE by two Subsystems in a mutually exclusive >> way. >> Use  "qcom,shared-se" flag in a particular i2c instance node if the >> usecase requires i2c controller to be shared. >> >> I2C driver just need to mark first_msg and last_msg flag to help indicate >> GPI driver to  take lock and unlock TRE there by protecting from >> concurrent >> access from other EE or Subsystem. >> >> gpi_create_i2c_tre() function at gpi.c will take care of adding Lock and >> Unlock TRE for the respective transfer operations. >> >> Since the GPIOs are also shared for the i2c bus between two SS, do not >> touch GPIO configuration during runtime suspend and only turn off the >> clocks. This will allow other SS to continue to transfer the data >> without any disturbance over the IO lines. > > This doesn't answer my question about what would be the behavior if one > use uses, for example, GPI DMA, and the Linux kernel FIFO mode or SE DMA ? > Shared usecase is not supported for non GSI mode (FIFO and DMA), it should be static usecase. Dynamic sharing from two clients of two subsystems is only for GSI mode. Hope this helps ? > Because it seems to "fix" only the GPI DMA shared case. > > Neil > >> >> Signed-off-by: Mukesh Kumar Savaliya >> --- >>   drivers/i2c/busses/i2c-qcom-geni.c | 29 ++++++++++++++++++++++------- >>   1 file changed, 22 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c >> b/drivers/i2c/busses/i2c-qcom-geni.c >> index eebb0cbb6ca4..ee2e431601a6 100644 >> --- a/drivers/i2c/busses/i2c-qcom-geni.c >> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >> @@ -1,5 +1,6 @@ >>   // SPDX-License-Identifier: GPL-2.0 >>   // Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. >> +// Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights >> reserved. >>   #include >>   #include >> @@ -99,6 +100,7 @@ struct geni_i2c_dev { >>       struct dma_chan *rx_c; >>       bool gpi_mode; >>       bool abort_done; >> +    bool is_shared; >>   }; >>   struct geni_i2c_desc { >> @@ -602,6 +604,7 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev >> *gi2c, struct i2c_msg msgs[], i >>       peripheral.clk_div = itr->clk_div; >>       peripheral.set_config = 1; >>       peripheral.multi_msg = false; >> +    peripheral.shared_se = gi2c->is_shared; >>       for (i = 0; i < num; i++) { >>           gi2c->cur = &msgs[i]; >> @@ -612,6 +615,8 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev >> *gi2c, struct i2c_msg msgs[], i >>           if (i < num - 1) >>               peripheral.stretch = 1; >> +        peripheral.first_msg = (i == 0); >> +        peripheral.last_msg = (i == num - 1); >>           peripheral.addr = msgs[i].addr; >>           ret =  geni_i2c_gpi(gi2c, &msgs[i], &config, >> @@ -631,8 +636,11 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev >> *gi2c, struct i2c_msg msgs[], i >>           dma_async_issue_pending(gi2c->tx_c); >>           time_left = wait_for_completion_timeout(&gi2c->done, >> XFER_TIMEOUT); >> -        if (!time_left) >> +        if (!time_left) { >> +            dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d >> addr:0x%x\n", >> +                        gi2c->cur->flags, gi2c->cur->addr); >>               gi2c->err = -ETIMEDOUT; >> +        } >>           if (gi2c->err) { >>               ret = gi2c->err; >> @@ -800,6 +808,11 @@ static int geni_i2c_probe(struct platform_device >> *pdev) >>           gi2c->clk_freq_out = KHZ(100); >>       } >> +    if (of_property_read_bool(pdev->dev.of_node, "qcom,shared-se")) { >> +        gi2c->is_shared = true; >> +        dev_dbg(&pdev->dev, "Shared SE Usecase\n"); >> +    } >> + >>       if (has_acpi_companion(dev)) >>           ACPI_COMPANION_SET(&gi2c->adap.dev, ACPI_COMPANION(dev)); >> @@ -962,14 +975,16 @@ static int __maybe_unused >> geni_i2c_runtime_suspend(struct device *dev) >>       struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); >>       disable_irq(gi2c->irq); >> -    ret = geni_se_resources_off(&gi2c->se); >> -    if (ret) { >> -        enable_irq(gi2c->irq); >> -        return ret; >> - >> +    if (gi2c->is_shared) { >> +        geni_se_clks_off(&gi2c->se); >>       } else { >> -        gi2c->suspended = 1; >> +        ret = geni_se_resources_off(&gi2c->se); >> +        if (ret) { >> +            enable_irq(gi2c->irq); >> +            return ret; >> +        } >>       } >> +    gi2c->suspended = 1; >>       clk_disable_unprepare(gi2c->core_clk); > >