From: Sinan Kaya <okaya@codeaurora.org>
To: Rob Herring <robh@kernel.org>, Vinod Koul <vinod.koul@intel.com>
Cc: linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: dmaengine: qcom_hidma: simplify DT resource parsing
Date: Thu, 4 Jan 2018 18:34:34 -0500 [thread overview]
Message-ID: <4169dc20-0c3d-d8b6-96ed-9b16c35be441@codeaurora.org> (raw)
On 1/4/2018 5:45 PM, Rob Herring wrote:
> The hidma driver open codes populating address and IRQ resources from DT.
> We have standard functions of_address_to_resource and of_irq_to_resource
> for this, so use them instead.
>
> The DT binding states each child should have 2 addresses and 1 IRQ, so we
> can simplify the logic and do a fixed size resource allocation. Using the
> standard of_address_to_resource will also do any address translation which
> was missing.
>
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: David Brown <david.brown@linaro.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-soc@vger.kernel.org
> Cc: dmaengine@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/dma/qcom/hidma_mgmt.c | 61 +++++++++++--------------------------------
> 1 file changed, 15 insertions(+), 46 deletions(-)
Thanks, this certainly looks cleaner. Mine was mostly copy/paste from other examples.
Reviewed-by: Sinan Kaya <okaya@codeaurora.org>
next reply other threads:[~2018-01-04 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 23:34 Sinan Kaya [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-08 17:02 dmaengine: qcom_hidma: simplify DT resource parsing Vinod Koul
2018-01-04 22:45 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4169dc20-0c3d-d8b6-96ed-9b16c35be441@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=david.brown@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).