DMA Engine development
 help / color / mirror / Atom feed
From: "Lynch, Nathan" <nathan.lynch@amd.com>
To: sashiko-reviews@lists.linux.dev
Cc: dmaengine@vger.kernel.org, linux-pci@vger.kernel.org,
	vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v4 11/25] dmaengine: sdxi: Start functions on probe, stop on remove
Date: Tue, 17 Nov 2026 16:10:24 -0600	[thread overview]
Message-ID: <44b0ea6c-5fdf-4b78-a5d1-43b68a715cb4@amd.com> (raw)
In-Reply-To: <sashiko-outbox-196576@kernel.org>

On 11/3/2026 9:04 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] dmaengine: sdxi: PF stopped before pci_disable_sriov() in sdxi_pci_remove()
> --
> 
> commit 44d5d7973859c1db8741ba90d53413150ded9a60
> Author: Nathan Lynch <nathan.lynch@amd.com>
> 
> dmaengine: sdxi: Start functions on probe, stop on remove
> 
> This commit activates the SDXI function during device registration by
> setting MMIO_CTL0.fn_gsr to GSRV_ACTIVE and polling for GSV_ACTIVE or
> GSV_ERROR, and stops the function via sdxi_unregister() on PCI removal.
> 
>> diff --git a/drivers/dma/sdxi/pci.c b/drivers/dma/sdxi/pci.c
>> index 6a293db69199f..d196ab5cf6f1c 100644
>> --- a/drivers/dma/sdxi/pci.c
>> +++ b/drivers/dma/sdxi/pci.c
>> @@ -99,6 +99,7 @@ static int sdxi_pci_probe(struct pci_dev *pdev,
>>  
>>  static void sdxi_pci_remove(struct pci_dev *pdev)
>>  {
>> +	sdxi_unregister(&pdev->dev);
>>  	pci_disable_sriov(pdev);
>>  }
> 
> [Severity: High]
> Should pci_disable_sriov(pdev) be called before sdxi_unregister(&pdev->dev)
> in sdxi_pci_remove()?
> 
> When SR-IOV virtual functions have been enabled via sriov_configure after PF
> registration, calling sdxi_unregister() first invokes sdxi_dev_stop() on the
> PF while the child VFs are still active and bound to their driver instances:
> 
> sdxi_pci_remove()
>   sdxi_unregister()
>     sdxi_dev_stop()
>       sdxi->bus_ops->reset() -> sdxi_pci_reset()
>         pci_reset_function_locked()
> 
> If the native MMIO stop sequence fails or times out, sdxi_dev_stop() falls
> back to sdxi_pci_reset() and issues a PF function-level reset (or clears bus
> mastering). A PF FLR clears PCI_SRIOV_CTRL_VFE in hardware and resets all VFs
> underneath their bound drivers, and pci_dev_restore() -> sriov_restore_state()
> then re-enables PCI_SRIOV_CTRL_VFE with uninitialized post-reset VFs before
> pci_disable_sriov(pdev) runs to unbind and remove them.
> 
> Calling pci_disable_sriov(pdev) before sdxi_unregister(&pdev->dev) would
> ensure all child VFs are unbound, stopped, and disabled before the PF itself
> is stopped or reset.

I've looked into this and consider it valid. Will fix in v5.


  reply	other threads:[~2026-11-17 22:10 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  2:49 [PATCH v4 00/25] dmaengine: Smart Data Accelerator Interface (SDXI) basic support Nathan Lynch via B4 Relay
2026-11-04  2:49 ` [PATCH v4 01/25] PCI: Add SNIA SDXI accelerator sub-class Nathan Lynch via B4 Relay
2026-11-05 18:10   ` Frank Li
2026-11-05 18:25     ` Lynch, Nathan
2026-11-12 21:28   ` Bjorn Helgaas
2026-11-04  2:49 ` [PATCH v4 02/25] MAINTAINERS: Add entry for SDXI driver Nathan Lynch via B4 Relay
2026-11-12 21:19   ` Frank Li
2026-11-17 21:52     ` Lynch, Nathan
2026-11-04  2:49 ` [PATCH v4 03/25] dmaengine: sdxi: Add PCI initialization Nathan Lynch via B4 Relay
2026-11-05 17:59   ` Frank Li
2026-11-05 18:07     ` Lynch, Nathan
2026-11-04  2:49 ` [PATCH v4 04/25] dmaengine: sdxi: Prepare function and sanitize MMIO state Nathan Lynch via B4 Relay
2026-11-12 21:26   ` Frank Li
2026-11-17 22:01     ` Lynch, Nathan
2026-11-04  2:49 ` [PATCH v4 05/25] dmaengine: sdxi: Feature discovery and initial configuration Nathan Lynch via B4 Relay
2026-11-12 21:32   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 06/25] dmaengine: sdxi: Configure context tables Nathan Lynch via B4 Relay
2026-11-12 21:49   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 07/25] dmaengine: sdxi: Allocate context control DMA pool Nathan Lynch via B4 Relay
2026-11-12 21:50   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 08/25] dmaengine: sdxi: Introduce submission queue Nathan Lynch via B4 Relay
2026-11-12 21:58   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 09/25] dmaengine: sdxi: Allocate administrative context Nathan Lynch via B4 Relay
2026-11-12 22:10   ` Frank Li
2026-11-17 22:08     ` Lynch, Nathan
2026-11-04  2:49 ` [PATCH v4 10/25] dmaengine: sdxi: Install " Nathan Lynch via B4 Relay
2026-11-12 22:17   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 11/25] dmaengine: sdxi: Start functions on probe, stop on remove Nathan Lynch via B4 Relay
2026-11-04  3:04   ` sashiko-bot
2026-11-17 22:10     ` Lynch, Nathan [this message]
2026-11-13 16:44   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 12/25] dmaengine: sdxi: Add client context allocation API Nathan Lynch via B4 Relay
2026-11-13 16:46   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 13/25] dmaengine: sdxi: Add descriptor ring management Nathan Lynch via B4 Relay
2026-11-13 16:51   ` Frank Li
2026-11-17 22:33     ` Lynch, Nathan
2026-11-04  2:49 ` [PATCH v4 14/25] dmaengine: sdxi: Add unit tests for descriptor ring reservations Nathan Lynch via B4 Relay
2026-11-04  3:02   ` sashiko-bot
2026-11-17 22:35     ` Lynch, Nathan
2026-11-13 16:53   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 15/25] dmaengine: sdxi: Per-context access key (AKey) table entry allocator Nathan Lynch via B4 Relay
2026-11-13 16:55   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 16/25] dmaengine: sdxi: Add completion status block API Nathan Lynch via B4 Relay
2026-11-13 17:04   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 17/25] dmaengine: sdxi: Add unit tests for completion pool ownership Nathan Lynch via B4 Relay
2026-11-13 17:07   ` Frank Li
2026-11-04  2:49 ` [PATCH v4 18/25] dmaengine: sdxi: Add context submission helper Nathan Lynch via B4 Relay
2026-11-13 17:12   ` Frank Li
2026-11-17 22:49     ` Lynch, Nathan
2026-11-04  2:50 ` [PATCH v4 19/25] dmaengine: sdxi: Encode context start, stop, update, and sync descriptors Nathan Lynch via B4 Relay
2026-11-05 16:52   ` Tycho Andersen
2026-11-17 22:51     ` Lynch, Nathan
2026-11-13 17:17   ` Frank Li
2026-11-17 23:00     ` Lynch, Nathan
2026-11-04  2:50 ` [PATCH v4 20/25] dmaengine: sdxi: Add client context release with update and sync Nathan Lynch via B4 Relay
2026-11-13 17:23   ` Frank Li
2026-11-04  2:50 ` [PATCH v4 21/25] dmaengine: sdxi: Provide context start and stop APIs Nathan Lynch via B4 Relay
2026-11-13 17:24   ` Frank Li
2026-11-04  2:50 ` [PATCH v4 22/25] dmaengine: sdxi: Encode copy and interrupt descriptors Nathan Lynch via B4 Relay
2026-11-05 17:00   ` Tycho Andersen
2026-11-13 17:28   ` Frank Li
2026-11-04  2:50 ` [PATCH v4 23/25] dmaengine: sdxi: Add unit tests for descriptor encoding Nathan Lynch via B4 Relay
2026-11-13 17:29   ` Frank Li
2026-11-04  2:50 ` [PATCH v4 24/25] dmaengine: sdxi: MSI/MSI-X vector allocation and mapping Nathan Lynch via B4 Relay
2026-11-04  3:15   ` sashiko-bot
2026-11-13 17:30     ` Frank Li
2026-11-13 17:36   ` Frank Li
2026-11-04  2:50 ` [PATCH v4 25/25] dmaengine: sdxi: Add DMA engine provider Nathan Lynch via B4 Relay
2026-11-04  3:24   ` sashiko-bot
2026-11-13 17:50   ` Frank Li
2026-11-13 23:34     ` Lynch, Nathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44b0ea6c-5fdf-4b78-a5d1-43b68a715cb4@amd.com \
    --to=nathan.lynch@amd.com \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox