public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
From: Khairul Anuar Romli <karom.9560@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	dmaengine@vger.kernel.org,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis
Date: Sun, 1 Feb 2026 07:45:45 +0800	[thread overview]
Message-ID: <4ae74b54-971a-4e92-8155-ef3fb00ccbda@gmail.com> (raw)
In-Reply-To: <425fd53d-9b97-4d4d-ba21-ef35d821c89b@web.de>

On 26/1/2026 7:12 pm, Markus Elfring wrote:
>> Correct alignment issue so that continuation lines properly match the
>> position of the opening parenthesis.
> 
> Line break?

Sure.
> 
> 
>>                                       This alignment issue were detected
> 
>                                         This issue was?
> 
Will put it in the next version

> 
>> with the help of the checkpatch.pl analysis tool with --strict --file
>> option.
> 
> Would it be nicer to put such information into another paragraph?
> 
Yeah, I will do this.

> 
>> - 'commit 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")'
>> - 'commit e32634f466a9 ("dma: dw-axi-dmac: support per channel
>>     interrupt")'
> 
> Is there a need to reformat such details a bit more?
> 
We are going back in the circle. I already put the details in the form 
of line and code but you mentioned I shall not list all the effected 
line before.

> 
> How do you think about to refine the summary phrase another bit?

I'll refine it.

> 
> Regards,
> Markus


Thanks.

Regards,
Khairul

  reply	other threads:[~2026-01-31 23:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 10:36 [PATCH v5 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli
2026-01-26 10:36 ` [PATCH v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli
2026-01-26 11:12   ` Markus Elfring
2026-01-31 23:45     ` Khairul Anuar Romli [this message]
2026-02-01  8:05       ` [v5 " Markus Elfring
2026-01-26 10:36 ` [PATCH v5 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli
2026-01-26 10:36 ` [PATCH v5 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements Khairul Anuar Romli
2026-01-26 11:22   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ae74b54-971a-4e92-8155-ef3fb00ccbda@gmail.com \
    --to=karom.9560@gmail.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=Markus.Elfring@web.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox