From: Dave Jiang <dave.jiang@intel.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: fix boolconv.cocci warnings
Date: Thu, 30 Jan 2020 09:13:03 -0700 [thread overview]
Message-ID: <4dd86f3a-6a83-061b-b1b8-2c745cb15e1d@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2001301543150.7476@hadrien>
On 1/30/20 7:44 AM, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
>
> Remove unneeded conversion to bool
>
> Generated by: scripts/coccinelle/misc/boolconv.cocci
>
> CC: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473
> commit: 42d279f9137ab7d5503836baec2739284b278d8f dmaengine: idxd: add char driver to expose submission portal to userland
> :::::: branch date: 11 hours ago
> :::::: commit date: 6 days ago
>
> Please take the patch only if it's a positive warning. Thanks!
>
> sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/dma/idxd/sysfs.c
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -66,7 +66,7 @@ static inline bool is_idxd_wq_dmaengine(
>
> static inline bool is_idxd_wq_cdev(struct idxd_wq *wq)
> {
> - return wq->type == IDXD_WQT_USER ? true : false;
> + return wq->type == IDXD_WQT_USER;
> }
>
> static int idxd_config_bus_match(struct device *dev,
>
next prev parent reply other threads:[~2020-01-30 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 14:44 [PATCH] dmaengine: idxd: fix boolconv.cocci warnings Julia Lawall
2020-01-30 16:13 ` Dave Jiang [this message]
2020-02-03 4:17 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dd86f3a-6a83-061b-b1b8-2c745cb15e1d@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=julia.lawall@inria.fr \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox