DMA Engine development
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Olivier Dautricourt <olivierdautricourt@gmail.com>,
	dmaengine@vger.kernel.org, Stefan Roese <sr@denx.de>,
	Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Eric Schwarz <eas@sw-optimization.com>
Subject: Re: [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks
Date: Sun, 9 Jun 2024 17:50:17 +0200	[thread overview]
Message-ID: <4e68aa3b-5ada-45da-98b4-4d79d959b48a@web.de> (raw)
In-Reply-To: <20240608213216.25087-1-olivierdautricourt@gmail.com>

I find that a cover letter can be helpful for the presented patch series.


> As we first take the lock with spin_lock_irqsave in msgdma_tasklet, Lockdep
…

I suggest to move the last word into the subsequent text line.

Regards,
Markus

  parent reply	other threads:[~2024-06-09 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-08 21:31 [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks Olivier Dautricourt
2024-06-08 21:31 ` [PATCH v2 2/3] dmaengine: altera-msgdma: cleanup after completing all descriptors Olivier Dautricourt
2024-06-09 17:20   ` Markus Elfring
2024-06-09 20:33     ` Olivier Dautricourt
2024-06-08 21:31 ` [PATCH v2 3/3] dmaengine: altera-msgdma: properly free descriptor in msgdma_free_descriptor Olivier Dautricourt
2024-06-09 17:30   ` Markus Elfring
2024-06-09 20:36     ` Olivier Dautricourt
2024-06-09 15:50 ` Markus Elfring [this message]
2024-06-11 18:28 ` [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e68aa3b-5ada-45da-98b4-4d79d959b48a@web.de \
    --to=markus.elfring@web.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=eas@sw-optimization.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olivierdautricourt@gmail.com \
    --cc=sr@denx.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox