DMA Engine development
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>, Jon Hunter <jgchunter@gmail.com>
Cc: dan.j.williams@intel.com, vkoul@kernel.org,
	dmaengine@vger.kernel.org, ldewangan@nvidia.com,
	linux-tegra@vger.kernel.org
Subject: [4/5] dma: tegra: reduce channel name field size
Date: Thu, 22 Nov 2018 15:24:48 +0000	[thread overview]
Message-ID: <550f145f-fbf5-083b-3735-711ba540d87e@nvidia.com> (raw)

On 22/11/2018 15:14, Ben Dooks wrote:
> On 22/11/2018 09:26, Jon Hunter wrote:
>> On Wed, Nov 21, 2018 at 4:15 PM Ben Dooks <ben.dooks@codethink.co.uk>
>> wrote:
>>>
>>> The name field is used for "apbdma.%d" which is rarely going to be
>>> more than 10 bytes, so reduce the size from 30 to 12. This is only
>>> being used by the interrupt registration, so is not critical to the
>>> operation of the driver either.
>>
>> Do you mean 'never' above instead of 'rarely'? The max number of
>> channels is never more than 2 digits and so the change is fine with
>> me. So for the change ...
> 
> I've never seen a system with more than 64 channels in it, but it didn't
> seem worth trying to get it below 12 anyway.

I see. If you look at the 'nr_channels' definition for the various Tegra
devices that use this driver, there is nothing more than 32. So for this
driver the max is 32. Newer Tegra devices are not using this anymore and
so in the case of this specific driver we can say 'never' (although I
understand now you meant rarely in the general case).

Cheers Jon

             reply	other threads:[~2018-11-22 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 15:24 Jon Hunter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-11-22 15:14 [4/5] dma: tegra: reduce channel name field size Ben Dooks
2018-11-22  9:26 Jon Hunter
2018-11-21 16:13 Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550f145f-fbf5-083b-3735-711ba540d87e@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=jgchunter@gmail.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox