From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3B354C62; Wed, 22 May 2024 06:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716360479; cv=none; b=bk98ThSlr0aAAdlw8MCr/SN4teGlZkqRqckChvgcwmfe9/pzh8hVkmJzKOAZjWUXoBZ4dt9cFKGDFLeEUabIv+in6TzHdjXO1nX1yUQBCxkoiD4ZHlfAIf+N2o2wSXKz9GxaD71NyqmmFRNkjt18feml2mP8gD7yMkyuL7c1RVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716360479; c=relaxed/simple; bh=fUIhzOfVUoWq4e5Mlr0tdY19EgBcj6SfhCRx1Nk6Vvc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XL4akTgw3huKKSRxUDTxwjlFQaE8LsGIvcQL3Cwd7ymH4WzKrj6gpi08MiEVQcrIJYwQyV+sg8iK/gPHjlETtZsAVyuS2Nz8+K2vumr0L+uwx/rQ9a722Sn/L3QPZJDyU0zdOjozdY1i373+oJ9UbASolBzB8bITeSWB7hxEbOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IP/ZfH47; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IP/ZfH47" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F796C2BD11; Wed, 22 May 2024 06:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716360479; bh=fUIhzOfVUoWq4e5Mlr0tdY19EgBcj6SfhCRx1Nk6Vvc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IP/ZfH47R13Tp6eCpcCvKQD+kEyYBG9CsM4JZ9jRZIFuibJPgK1SkM/20TrcLcH91 rhXXPdvPFZogdJtAaxQFuKg0p5RUrQj4ySLrbbL1z6bA0cpBmhO7LmeelWXGq8R2/O efiXbHJckVMvggjLnA2GrswM9DWUkNKHkxDiB/UfY+zxU/RGDndsxRPsNLFGdyZaXx 4MscVaoefqe0/55Qx+CGGVTmnZdptDovqUQhfGd88CO0p4JyyEJR8OyyRwrxAx/O0k HhdhYpE1pAM0PQfVDGKkUzmqRVZTX8qLxMJqXzE0PI+k5uupbvbSoTAKmgdMQ+Cem4 K8gIngW6ELWkQ== Message-ID: <56bf93ac-6c1e-48aa-89d0-7542ea707848@kernel.org> Date: Wed, 22 May 2024 08:47:52 +0200 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH 1/2] dt-bindings: dma: Add reg-names to nvidia,tegra210-adma To: Sameer Pujar , vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, ldewangan@nvidia.com, mkumard@nvidia.com References: <20240521110801.1692582-1-spujar@nvidia.com> <20240521110801.1692582-2-spujar@nvidia.com> <80b6e6e6-9805-4a85-97d5-38e1b2bf2dd0@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/05/2024 07:35, Sameer Pujar wrote: > > > On 21-05-2024 17:23, Krzysztof Kozlowski wrote: >> On 21/05/2024 13:08, Sameer Pujar wrote: >>> From: Mohan Kumar >>> >>> For Non-Hypervisor mode, Tegra ADMA driver requires the register >>> resource range to include both global and channel page in the reg >>> entry. For Hypervisor more, Tegra ADMA driver requires only the >>> channel page and global page range is not allowed for access. >>> >>> Add reg-names DT binding for Hypervisor mode to help driver to >>> differentiate the config between Hypervisor and Non-Hypervisor >>> mode of execution. >>> >>> Signed-off-by: Mohan Kumar >>> Signed-off-by: Sameer Pujar >>> --- >>> .../devicetree/bindings/dma/nvidia,tegra210-adma.yaml | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml >>> index 877147e95ecc..ede47f4a3eec 100644 >>> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml >>> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml >>> @@ -29,8 +29,18 @@ properties: >>> - const: nvidia,tegra186-adma >>> >>> reg: >>> + description: | >>> + For hypervisor mode, the address range should include a >>> + ADMA channel page address range, for non-hypervisor mode >>> + it starts with ADMA base address covering Global and Channel >>> + page address range. >>> maxItems: 1 >>> >>> + reg-names: >>> + description: only required for Hypervisor mode. >> This does not work like that. I provide vm entry for non-hypervisor mode >> and what? You claim it is virtualized? >> >> Drop property. > > With 'vm' entry added for hypervisor mode, the 'reg' address range needs > to be updated to use channel specific region only. This is used to > inform driver to skip global regions which is taken care by hypervisor. > This is expected to be used in the scenario where Linux acts as a > virtual machine (VM). May be the hypervisor mode gives a different > impression here? Sorry, I did not understand what dropping the property > exactly means here. It was imperative. Drop it. Remove it. I provided explanation why. Also, drop unneeded |. Best regards, Krzysztof