From: Jon Hunter <jonathanh@nvidia.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
Sameer Pujar <spujar@nvidia.com>,
vkoul@kernel.org, dan.j.williams@intel.com, tglx@linutronix.de,
jason@lakedaemon.net
Cc: thierry.reding@gmail.com, ldewangan@nvidia.com,
mkumard@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: [3/3] irqchip/gic-pm: use devm_clk_*() helpers
Date: Wed, 6 Mar 2019 12:00:02 +0000 [thread overview]
Message-ID: <573022cf-e2e3-0e12-d16c-6d465b8af2ce@nvidia.com> (raw)
On 06/03/2019 11:31, Marc Zyngier wrote:
> Hi Sameer,
>
> [unrelated to this email: anything that comes from NVIDIA reaches me
> encrypted with my public key. Not a big deal, but it'd be good if
> someone could fix that.]
>
> On 06/03/2019 10:41, Sameer Pujar wrote:
>> With pm_clk_*() usage, it is seen that clocks always remain ON. This
>> happens because clocks are managed by BPMP on Tegra devices and clock
>> enable/disable happens during prepare/unprepare phase. This patch
>> avoids use of pm_clk_*() and replaces it with devm_clk_*() helpers.
>>
>> Suggested-by: Mohan Kumar D <mkumard@nvidia.com>
>> Reviewed-by: Jonathan Hunter <jonathanh@nvidia.com>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>
> On its own, I'm not opposed to that patch.
>
> But given that there is no in-tree platform using this, despite the code
> sitting here for more than 2.5 years, this is just updating dead code.
>
> Am I missing anything?
Nope, but we are working to fix that at long last. I hope in the next
few months it will not longer be dormant! This driver is still very much
important to our audio support for newer Tegra devices.
Cheers
Jon
next reply other threads:[~2019-03-06 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 12:00 Jon Hunter [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-06 13:21 [3/3] irqchip/gic-pm: use devm_clk_*() helpers Marc Zyngier
2019-03-06 11:31 Marc Zyngier
2019-03-06 10:41 Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573022cf-e2e3-0e12-d16c-6d465b8af2ce@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mkumard@nvidia.com \
--cc=spujar@nvidia.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox