From: David Heidelberg <david@ixit.cz>
To: bjorn.andersson@oss.qualcomm.com
Cc: djakov@kernel.org, dmaengine@vger.kernel.org,
dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_mdalam@quicinc.com,
vkoul@kernel.org
Subject: Re: [PATCH] dmaengine: qcom: bam_dma: Avoid accessing BAM_REVISION on remote BAM
Date: Sun, 9 Feb 2025 16:19:53 +0100 [thread overview]
Message-ID: <5cc3639f-2689-4e4a-a89b-02ade0efe966@ixit.cz> (raw)
In-Reply-To: <20250207-bam-read-fix-v1-1-027975cf1a04@oss.qualcomm.com>
On 7.02.25 22:17, Bjorn Andersson wrote:
> Commit '57a7138d0627 ("dmaengine: qcom: bam_dma: Avoid writing
> unavailable register")' made this read unconditional, in order to
> identify if the instance is BAM-NDP or BAM-Lite.
> But the BAM_REVISION register is not accessible on remotely managed BAM
> instances and attempts to access it causes the system to crash.
>
> Move the access back to be conditional and expand the checks that was
> introduced to restore the old behavior when no revision information is
> available.
>
> Fixes: 57a7138d0627 ("dmaengine: qcom: bam_dma: Avoid writing
unavailable register")
> Reported-by: Georgi Djakov <djakov@kernel.org>
> Closes:
https://lore.kernel.org/lkml/9ef3daa8-cdb1-49f2-8d19-a72d6210ff3a@kernel.org/
> Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Tested-by: David Heidelberg <david@ixit.cz> # OnePlus 6T
--
David Heidelberg
next prev parent reply other threads:[~2025-02-09 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 20:17 [PATCH] dmaengine: qcom: bam_dma: Avoid accessing BAM_REVISION on remote BAM Bjorn Andersson
2025-02-08 11:47 ` Sam Day
2025-02-08 12:42 ` Georgi Djakov
2025-02-09 15:19 ` David Heidelberg [this message]
2025-02-10 8:44 ` Stephan Gerhold
2025-02-10 11:48 ` Md Sadre Alam
2025-02-12 2:43 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cc3639f-2689-4e4a-a89b-02ade0efe966@ixit.cz \
--to=david@ixit.cz \
--cc=20250207-bam-read-fix-v1-1-027975cf1a04@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=djakov@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mdalam@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox