From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC69C73C7C for ; Wed, 10 Jul 2019 08:38:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BDD920838 for ; Wed, 10 Jul 2019 08:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="T9Pms+Zr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727326AbfGJIim (ORCPT ); Wed, 10 Jul 2019 04:38:42 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:9701 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727142AbfGJIim (ORCPT ); Wed, 10 Jul 2019 04:38:42 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 10 Jul 2019 01:38:40 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 10 Jul 2019 01:38:41 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 10 Jul 2019 01:38:41 -0700 Received: from [10.26.11.158] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 10 Jul 2019 08:38:39 +0000 Subject: Re: [PATCH] dmaengine: tegra210-adma: Fix unused function warnings To: YueHaibing , , , , CC: , , References: <20190709083258.57112-1-yuehaibing@huawei.com> From: Jon Hunter Message-ID: <5cda4486-d875-4f66-c7f9-0ed11e35d44c@nvidia.com> Date: Wed, 10 Jul 2019 09:38:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190709083258.57112-1-yuehaibing@huawei.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1562747920; bh=1FBvMektmbZBOzVKmJaAz9QLeVX25uyKcUKzcf9Hdc0=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=T9Pms+Zrm7JkZZNSCGxO4a298/jArN10Cp+rQr/lxgrDM70EAU2KYkR93A75VFXt+ jkpj0A2Wi4y87LlBNCvQhpvkGAd00yzdVgoVZOODKI30WznCPPTAfIuog2S3rdQaA1 ynXq3sE1v0nDpuBTPN1iAB0ll8oZtrDULou9vNS5Z/Xu2v/ffM80aLF+OAz3GUd8vt m8mmYL4ZnfZvgbJxQ/CZJBAD4TfjZlHMuEzX2UdYdT740Jb4GPpPgl9REDRRURXhj/ EiSTaumDmU19T8kN2qFDMFn39Km2YtALrYTwYWu6qBNsB2jzmTB2RpbhMeykYWsIW/ KNJbEG5qKWldw== Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 09/07/2019 09:32, YueHaibing wrote: > If CONFIG_PM is not set, build warnings: > > drivers/dma/tegra210-adma.c:747:12: warning: tegra_adma_runtime_resume defined but not used [-Wunused-function] > static int tegra_adma_runtime_resume(struct device *dev) > drivers/dma/tegra210-adma.c:715:12: warning: tegra_adma_runtime_suspend defined but not used [-Wunused-function] > static int tegra_adma_runtime_suspend(struct device *dev) > > Mark the two function as __maybe_unused. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/dma/tegra210-adma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c > index 2805853..b33cf6e 100644 > --- a/drivers/dma/tegra210-adma.c > +++ b/drivers/dma/tegra210-adma.c > @@ -712,7 +712,7 @@ static struct dma_chan *tegra_dma_of_xlate(struct of_phandle_args *dma_spec, > return chan; > } > > -static int tegra_adma_runtime_suspend(struct device *dev) > +static int __maybe_unused tegra_adma_runtime_suspend(struct device *dev) > { > struct tegra_adma *tdma = dev_get_drvdata(dev); > struct tegra_adma_chan_regs *ch_reg; > @@ -744,7 +744,7 @@ static int tegra_adma_runtime_suspend(struct device *dev) > return 0; > } > > -static int tegra_adma_runtime_resume(struct device *dev) > +static int __maybe_unused tegra_adma_runtime_resume(struct device *dev) > { > struct tegra_adma *tdma = dev_get_drvdata(dev); > struct tegra_adma_chan_regs *ch_reg; > Thanks! Acked-by: Jon Hunter Cheers Jon -- nvpublic