From: Krzysztof Kozlowski <krzk@kernel.org>
To: vkoul@kernel.org
Cc: Liao Yuanhong <liaoyuanhong@vivo.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v2 0/7] dmaengine:Use devm_clk_get_enabled() helpers
Date: Fri, 30 Aug 2024 20:11:56 +0200 [thread overview]
Message-ID: <6829a2e4-f7e0-4f34-8702-e00b005e9e0c@kernel.org> (raw)
In-Reply-To: <20240830094118.15458-1-liaoyuanhong@vivo.com>
On 30/08/2024 11:41, Liao Yuanhong wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids the calls to clk_disable_unprepare().
> ---
> v2:remove inappropriate modifications, configure COMPILE_TEST for easy
> testing, add devm_clk_getprepaed() for imx sdma device.
> ---
>
Vinod,
Since ~2 weeks there is tremendous amount of trivial patches coming from
vivo.com. I identified at least 6 buggy, where the contributor did not
understand the code. Not sure about intention, but I advise extra
carefulness
when dealing with these "trivial" improvements.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-30 18:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 9:41 [PATCH v2 0/7] dmaengine:Use devm_clk_get_enabled() helpers Liao Yuanhong
2024-08-30 9:41 ` [PATCH v2 1/7] dmaengine:Add COMPILE_TEST for easy testing Liao Yuanhong
2024-08-30 17:44 ` Krzysztof Kozlowski
2024-08-31 13:15 ` kernel test robot
2024-08-31 21:31 ` kernel test robot
2024-08-30 9:41 ` [PATCH v2 2/7] dmaengine:at_hdmac:Use devm_clk_get_enabled() helpers Liao Yuanhong
2024-08-30 12:24 ` Nicolas Ferre
2024-08-30 9:41 ` [PATCH v2 3/7] dmaengine:dma-jz4780:Use " Liao Yuanhong
2024-08-30 9:41 ` [PATCH v2 4/7] dmaengine:imx-dma:Use " Liao Yuanhong
2024-08-30 15:12 ` Frank Li
2024-08-30 9:41 ` [PATCH v2 5/7] dmaengine:imx-sdma:Use devm_clk_get_prepared() helpers Liao Yuanhong
2024-08-30 15:11 ` Frank Li
2024-08-30 9:41 ` [PATCH v2 6/7] dmaengine:milbeaut-hdmac:Use devm_clk_get_enabled() helpers Liao Yuanhong
2024-08-30 9:41 ` [PATCH v2 7/7] dmaengine:uniphier-mdmac:Use " Liao Yuanhong
2024-08-30 18:11 ` Krzysztof Kozlowski [this message]
2024-09-03 5:18 ` [PATCH v2 0/7] dmaengine:Use " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6829a2e4-f7e0-4f34-8702-e00b005e9e0c@kernel.org \
--to=krzk@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=liaoyuanhong@vivo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox