From: Dmitry Osipenko <digetx@gmail.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: dan.j.williams@intel.com, vkoul@kernel.org, ldewangan@nvidia.com,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [4/6] dma: tegra: add accurate reporting of dma state
Date: Sun, 14 Apr 2019 18:20:27 +0300 [thread overview]
Message-ID: <687294f3-aeb5-f17f-bf7d-886346baf02d@gmail.com> (raw)
22.02.2019 21:10, Dmitry Osipenko пишет:
> 22.02.2019 20:23, Ben Dooks пишет:
>> On 21/02/2019 13:02, Dmitry Osipenko wrote:
>>> 21.02.2019 13:06, Ben Dooks пишет:
>>>> On 21/02/2019 00:41, Dmitry Osipenko wrote:
>>>>> 31.10.2018 19:03, Ben Dooks пишет:
>>>>>> The tx_status callback does not report the state of the transfer
>>>>>> beyond complete segments. This causes problems with users such as
>>>>>> ALSA when applications want to know accurately how much data has
>>>>>> been moved.
>>>>>>
>>>>>> This patch addes a function tegra_dma_update_residual() to query
>>>>>> the hardware and modify the residual information accordinly. It
>>>>>> takes into account any hardware issues when trying to read the
>>>>>> state, such as delays between finishing a buffer and signalling
>>>>>> the interrupt.
>>>>>>
>>>>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>>>>
>>>>> Hello Ben,
>>>>>
>>>>> Do you have any plans to submit a new version of this patch? It's really useful and fixes a real problem with the audio playback. I could help with finalizing the patch and could submit it for you if you happened to lost the interest.
>>>>
>>>> Personally I think the original version was fine. It has been tested
>>>> and returns fairly quickly (I am not a fan of just adding more delay in)
>>>>
>>>> My notes say the condition doesn't last for long and the loop tends
>>>> to terminate within 2 runs.
>>>>
>>>
>>> Okay, so are you going to re-send the patch? We can back to the review after, you need at least to re-send because this series has been outdated. Also please take a look and feel free to use as-is the reduced variant of yours patch that I was carrying and testing for months now [0], it works great.
>>>
>>> [0] https://github.com/grate-driver/linux/commit/ab8a67a6f47185f265f16749b55df214aaaefad4
>>>
>>
>> I can try rebasing, but I have not got a lot of time to do any testing
>> at the moment. I agree I should have remembered to chase this stuff up
>> earlier.
>
> No problems, thank you. I'll help with the testing. And I could rebase the patch and send it out for you if will be needed, please just let me know if you're okay with it.
>
Hello Ben,
Do you have any status update on the state of the patch? Again, I could help with sending it out for you if you're too busy or something else. Please let me know how we could proceed with getting the fix upstreamed and sorry for disturbing you again with this.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: dan.j.williams@intel.com, vkoul@kernel.org, ldewangan@nvidia.com,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 4/6] dma: tegra: add accurate reporting of dma state
Date: Sun, 14 Apr 2019 18:20:27 +0300 [thread overview]
Message-ID: <687294f3-aeb5-f17f-bf7d-886346baf02d@gmail.com> (raw)
Message-ID: <20190414152027.UsV_JI5bUumRpaaz_SSVlOkJ8OGCYyOt9u5Ykb77HHU@z> (raw)
In-Reply-To: <85a8afa6-8b0d-dcc2-3254-a79cf90e90df@gmail.com>
22.02.2019 21:10, Dmitry Osipenko пишет:
> 22.02.2019 20:23, Ben Dooks пишет:
>> On 21/02/2019 13:02, Dmitry Osipenko wrote:
>>> 21.02.2019 13:06, Ben Dooks пишет:
>>>> On 21/02/2019 00:41, Dmitry Osipenko wrote:
>>>>> 31.10.2018 19:03, Ben Dooks пишет:
>>>>>> The tx_status callback does not report the state of the transfer
>>>>>> beyond complete segments. This causes problems with users such as
>>>>>> ALSA when applications want to know accurately how much data has
>>>>>> been moved.
>>>>>>
>>>>>> This patch addes a function tegra_dma_update_residual() to query
>>>>>> the hardware and modify the residual information accordinly. It
>>>>>> takes into account any hardware issues when trying to read the
>>>>>> state, such as delays between finishing a buffer and signalling
>>>>>> the interrupt.
>>>>>>
>>>>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>>>>
>>>>> Hello Ben,
>>>>>
>>>>> Do you have any plans to submit a new version of this patch? It's really useful and fixes a real problem with the audio playback. I could help with finalizing the patch and could submit it for you if you happened to lost the interest.
>>>>
>>>> Personally I think the original version was fine. It has been tested
>>>> and returns fairly quickly (I am not a fan of just adding more delay in)
>>>>
>>>> My notes say the condition doesn't last for long and the loop tends
>>>> to terminate within 2 runs.
>>>>
>>>
>>> Okay, so are you going to re-send the patch? We can back to the review after, you need at least to re-send because this series has been outdated. Also please take a look and feel free to use as-is the reduced variant of yours patch that I was carrying and testing for months now [0], it works great.
>>>
>>> [0] https://github.com/grate-driver/linux/commit/ab8a67a6f47185f265f16749b55df214aaaefad4
>>>
>>
>> I can try rebasing, but I have not got a lot of time to do any testing
>> at the moment. I agree I should have remembered to chase this stuff up
>> earlier.
>
> No problems, thank you. I'll help with the testing. And I could rebase the patch and send it out for you if will be needed, please just let me know if you're okay with it.
>
Hello Ben,
Do you have any status update on the state of the patch? Again, I could help with sending it out for you if you're too busy or something else. Please let me know how we could proceed with getting the fix upstreamed and sorry for disturbing you again with this.
next prev reply other threads:[~2019-04-14 15:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181031160309.20408-1-ben.dooks@codethink.co.uk>
2018-10-31 16:03 ` [4/6] dma: tegra: add accurate reporting of dma state Ben Dooks
2019-02-21 0:41 ` Dmitry Osipenko
2019-02-21 10:06 ` Ben Dooks
2019-02-21 13:02 ` Dmitry Osipenko
2019-02-22 17:23 ` Ben Dooks
2019-02-22 18:10 ` Dmitry Osipenko
2019-04-14 15:20 ` Dmitry Osipenko [this message]
2019-04-14 15:20 ` [PATCH 4/6] " Dmitry Osipenko
2019-04-15 15:01 ` [4/6] " Ben Dooks
2019-04-15 15:01 ` [PATCH 4/6] " Ben Dooks
2019-04-15 16:56 ` [4/6] " Dmitry Osipenko
2019-04-15 16:56 ` [PATCH 4/6] " Dmitry Osipenko
2018-11-05 14:05 [4/6] " Dmitry Osipenko
-- strict thread matches above, loose matches on Subject: below --
2018-11-05 11:38 Jon Hunter
2018-11-05 11:34 Ben Dooks
2018-11-05 11:32 Jon Hunter
2018-11-05 9:03 Ben Dooks
2018-11-03 12:24 Dmitry Osipenko
2018-10-12 21:47 kbuild test robot
2018-10-12 9:44 Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687294f3-aeb5-f17f-bf7d-886346baf02d@gmail.com \
--to=digetx@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).