From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abin Joseph <abin.joseph@amd.com>,
vkoul@kernel.org, michal.simek@amd.com, robh@kernel.org,
u.kleine-koenig@pengutronix.de, krzk+dt@kernel.org,
conor+dt@kernel.org, radhey.shyam.pandey@amd.com,
harini.katakam@amd.com
Cc: git@amd.com, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: zynqmp_dma: Add support for AMD Versal Gen 2 DMA IP
Date: Fri, 26 Jul 2024 11:12:50 +0200 [thread overview]
Message-ID: <6947bdc7-cbcc-4a5b-a6f4-8d213f1cda4d@kernel.org> (raw)
In-Reply-To: <20240726062639.2609974-3-abin.joseph@amd.com>
On 26/07/2024 08:26, Abin Joseph wrote:
> ZynqMp DMA IP and AMD Versal Gen 2 DMA IP are similar but have different
> interrupt register offset. Create a dedicated compatible string to
> support Versal Gen 2 DMA IP with Irq register offset for interrupt
> Enable/Disable/Status/Mask functionality.
>
>
> /**
> @@ -919,6 +924,9 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev,
> return -EINVAL;
> }
>
> + if (of_device_is_compatible(node, "amd,versal2-dma-1.0"))
> + chan->irq_offset = IRQ_REG_OFFSET;
Do not sprinkle compatibles, but use match data.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-26 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 6:26 [PATCH 0/2] Add support for ADMA Abin Joseph
2024-07-26 6:26 ` [PATCH 1/2] dt-bindings: dmaengine: zynqmp_dma: Add a new compatible string Abin Joseph
2024-07-26 9:13 ` Krzysztof Kozlowski
2024-07-26 6:26 ` [PATCH 2/2] dmaengine: zynqmp_dma: Add support for AMD Versal Gen 2 DMA IP Abin Joseph
2024-07-26 9:12 ` Krzysztof Kozlowski [this message]
2024-08-05 16:53 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6947bdc7-cbcc-4a5b-a6f4-8d213f1cda4d@kernel.org \
--to=krzk@kernel.org \
--cc=abin.joseph@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).