From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod <vkoul@kernel.org>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
grygorii.strashko@ti.com
Subject: [RFC,4/5] dmaengine: ti: New driver for K3 UDMA
Date: Wed, 10 Oct 2018 09:53:43 +0300 [thread overview]
Message-ID: <6cdeb80d-d62f-aee8-e3e1-7a6dec40fe86@ti.com> (raw)
On 2018-10-10 07:00, Vinod wrote:
>> drivers/dma/ti/Kconfig | 12 +
>> drivers/dma/ti/Makefile | 1 +
>> drivers/dma/ti/k3-udma.c | 3623 +++++++++++++++++++++++++++++
>
> Sorry but that's too big to review, please split it up
>
> ...
>
> I tried to review but it is too long, can you split to possibly, struct
> and io accessors, then low level function and dma callbacks at the end..
Hrm, I can try that.
>> drivers/dma/ti/k3-udma.h | 132 ++
>> include/dt-bindings/dma/k3-udma.h | 26 +
>> 5 files changed, 3794 insertions(+)
>> create mode 100644 drivers/dma/ti/k3-udma.c
>> create mode 100644 drivers/dma/ti/k3-udma.h
>> create mode 100644 include/dt-bindings/dma/k3-udma.h
>>
>> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
>> new file mode 100644
>> index 000000000000..2a2a2c8b1fc2
>> --- /dev/null
>> +++ b/drivers/dma/ti/k3-udma.c
>> @@ -0,0 +1,3623 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2018 Texas Instruments Incorporated - http://www.ti.com
>> + * Author: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> + */
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/delay.h>
>> +#include <linux/dmaengine.h>
>> +#include <linux/dma-mapping.h>
>> +#include <linux/dmapool.h>
>> +#include <linux/err.h>
>> +#include <linux/init.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/list.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/pm_runtime.h>
>> +#include <linux/slab.h>
>> +#include <linux/spinlock.h>
>> +#include <linux/of.h>
>> +#include <linux/of_dma.h>
>> +#include <linux/of_device.h>
>> +#include <linux/of_irq.h>
>
> Do you really need all of_ variants?
Yes, they are needed:
of_dma.h -> of_dma support
of_device.h -> of_find_device_by_node()
of_irq.h -> of_irq_find_parent()
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next reply other threads:[~2018-10-10 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 6:53 Peter Ujfalusi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-10 4:00 [RFC,4/5] dmaengine: ti: New driver for K3 UDMA Vinod Koul
2018-09-24 13:00 Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cdeb80d-d62f-aee8-e3e1-7a6dec40fe86@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox