From: "Csókás Bence" <csokas.bence@prolan.hu>
To: Markus Elfring <Markus.Elfring@web.de>,
<dmaengine@vger.kernel.org>, <linux-sunxi@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Chen-Yu Tsai <wens@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v6] dma-engine: sun4i: Simplify error handling in probe()
Date: Tue, 25 Mar 2025 09:26:28 +0100 [thread overview]
Message-ID: <7064597b-caf7-42e2-b083-b3531e874200@prolan.hu> (raw)
In-Reply-To: <92772f63-52c9-4979-9b60-37c8320ca009@web.de>
Hi,
On 2025. 03. 24. 18:55, Markus Elfring wrote:
>> Clean up error handling by using devm functions and dev_err_probe().
> …
>
> Do any contributors care for a different patch granularity?
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n81
I still don't understand why you are so adamant on this. It is just a
simple refactor patch changing 33 lines, mostly in one function, with no
logic change. Does it break something in your system? Please explain
yourself so we can understand your viewpoint better.
> Will it be clearer to mention also the function name “sun4i_dma_probe”
> in the summary phrases?
I already added it as per your last response, did you not read the message?
On 2025. 03. 24. 18:20, Bence Csókás wrote:
> Clean up error handling by using devm functions and dev_err_probe(). This
> should make it easier to add new code, as we can eliminate the "goto
> ladder" in sun4i_dma_probe().
Bence
next prev parent reply other threads:[~2025-03-25 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 17:20 [PATCH v6] dma-engine: sun4i: Simplify error handling in probe() Bence Csókás
2025-03-24 17:55 ` Markus Elfring
2025-03-25 8:26 ` Csókás Bence [this message]
2025-03-25 8:47 ` [v6] " Markus Elfring
2025-03-25 8:58 ` Csókás Bence
2025-03-25 9:12 ` Markus Elfring
2025-03-25 12:20 ` Julian Calaby
2025-03-25 12:38 ` Markus Elfring
2025-03-25 12:39 ` Csókás Bence
2025-03-25 13:04 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7064597b-caf7-42e2-b083-b3531e874200@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=Markus.Elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox