From: Dmitry Osipenko <digetx@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Krishna Yarlagadda <kyarlagadda@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
Rajesh Gumasta <rgumasta@nvidia.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"vkoul@kernel.org" <vkoul@kernel.org>
Cc: Pavan Kunapuli <pkunapuli@nvidia.com>
Subject: Re: [PATCH v14 2/4] dmaengine: tegra: Add tegra gpcdma driver
Date: Wed, 15 Dec 2021 17:56:21 +0300 [thread overview]
Message-ID: <70cce574-4022-16a9-ae10-4b84696d21d5@gmail.com> (raw)
In-Reply-To: <BN9PR12MB52738F4B5B7494466A9CB5A1C0769@BN9PR12MB5273.namprd12.prod.outlook.com>
15.12.2021 16:50, Akhil R пишет:
>> 06.12.2021 16:00, Akhil R пишет:
>>> +static const struct __maybe_unused dev_pm_ops tegra_dma_dev_pm_ops =
>> {
>>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(tegra_dma_pm_suspend,
>>> +tegra_dma_pm_resume) };
>>
>> Why late?
> To wait for the drivers using the dma to be suspended so that they
> don't keep the dma busy.
> Agree with the other comments.
Drivers are suspended in the opposite order to the probe order. DMA
controller driver is always probed first. The "late" is unneeded, please
see tegra20-apb-dma driver for the example.
next prev parent reply other threads:[~2021-12-15 14:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 13:00 [PATCH v14 0/4] Add NVIDIA Tegra GPC-DMA driver Akhil R
2021-12-06 13:00 ` [PATCH v14 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma Akhil R
2021-12-10 16:44 ` Rob Herring
2021-12-06 13:00 ` [PATCH v14 2/4] dmaengine: tegra: Add tegra gpcdma driver Akhil R
2021-12-09 17:10 ` Thierry Reding
2021-12-09 21:19 ` Dmitry Osipenko
2021-12-09 21:23 ` Dmitry Osipenko
2021-12-15 13:50 ` Akhil R
2021-12-15 14:56 ` Dmitry Osipenko [this message]
2021-12-09 21:26 ` Dmitry Osipenko
2021-12-09 21:37 ` Dmitry Osipenko
2021-12-06 13:00 ` [PATCH v14 3/4] arm64: defconfig: tegra: Enable GPCDMA Akhil R
2021-12-06 13:00 ` [PATCH v14 4/4] arm64: tegra: Add GPCDMA node for tegra186 and tegra194 Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70cce574-4022-16a9-ae10-4b84696d21d5@gmail.com \
--to=digetx@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pkunapuli@nvidia.com \
--cc=rgumasta@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox