From: Krzysztof Kozlowski <krzk@kernel.org>
To: CL Wang <cl634@andestech.com>, Conor Dooley <conor@kernel.org>
Cc: vkoul@kernel.org, dmaengine@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
tim609@andestech.com
Subject: Re: [PATCH V1 1/2] dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine
Date: Tue, 7 Oct 2025 23:27:12 +0900 [thread overview]
Message-ID: <734de17e-a712-4eb5-96fa-b7e75f86d880@kernel.org> (raw)
In-Reply-To: <aOUIfaZY7-eUYoOS@swlinux02>
On 07/10/2025 21:33, CL Wang wrote:
> Hi Conor,
>
> Thanks for your review.
>
> Yes, the DMA driver supports the Qilai platform. I have updated the DTS binding as shown below.
> Could you please take a look and let me know if anything still needs to be adjusted?
>
> properties:
> compatible:
> - const: andestech,atcdmac300
> + oneOf:
> + - items:
> + - enum:
> + - andestech,qilai-dma
> + - const: andestech,atcdmac300
> + - const: andestech,atcdmac300
> ...
> dma-controller@f0c00000 {
> - compatible = "andestech,atcdmac300";
> + compatible = "andestech,qilai-dma", "andestech,atcdmac300";
What is "atcdmac300" then? Usually the recommendation is to go only with
soc-based compatibles, not IP blocks. See also:
https://elixir.bootlin.com/linux/v6.17.1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-07 14:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 13:16 [PATCH V1 0/2] dmaengine: atcdmac300: Add Andes ATCDMAC300 DMA driver CL Wang
2025-10-02 13:16 ` [PATCH V1 1/2] dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine CL Wang
2025-10-02 18:40 ` Conor Dooley
2025-10-07 12:33 ` CL Wang
2025-10-07 14:27 ` Krzysztof Kozlowski [this message]
2025-10-08 3:13 ` CL Wang
2025-10-08 8:04 ` Krzysztof Kozlowski
2025-10-08 13:35 ` CL Wang
2025-10-08 20:45 ` Conor Dooley
2025-10-08 23:48 ` Krzysztof Kozlowski
2025-10-09 8:40 ` CL Wang
2025-10-02 13:16 ` [PATCH V1 2/2] dmaengine: atcdmac300: Add driver for Andes ATCDMAC300 DMA controller CL Wang
2025-10-03 17:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734de17e-a712-4eb5-96fa-b7e75f86d880@kernel.org \
--to=krzk@kernel.org \
--cc=cl634@andestech.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tim609@andestech.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).