From: "Arnd Bergmann" <arnd@arndb.de>
To: "Frank Li" <Frank.li@nxp.com>
Cc: "Vinod Koul" <vkoul@kernel.org>, "Baoquan He" <bhe@redhat.com>,
dmaengine@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
imx@lists.linux.dev, linux-kernel@vger.kernel.org,
"kernel test robot" <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v5 1/3] debugfs_create_regset32() support 8/16 bit width registers
Date: Mon, 02 Oct 2023 21:39:37 +0200 [thread overview]
Message-ID: <77c827ac-06a3-44fc-97ff-45db82ac0206@app.fastmail.com> (raw)
In-Reply-To: <ZRsU2gfjxAAOiHyy@lizhi-Precision-Tower-5810>
On Mon, Oct 2, 2023, at 21:07, Frank Li wrote:
> On Mon, Oct 02, 2023 at 08:55:23PM +0200, Arnd Bergmann wrote:
>
>> A few other thoughts from my side, all of which could be ignored:
>>
>> - if the ioport access is not an important feature, we can instead
>> support 64-bit readl() as I commented in a previous email. We just
>> can't easily have both.
>
> We will get 64bit dma edma soon. So I can test and upstream it when I get
> it.
Ok, so if we already know this is going to be needed, then I would skip
the PIO support and just use read{bwlq}() with the optional swab() instead
of the ioread variants. Otherwise there is a risk that someone starts
relying on the port I/O feature and make it harder to remove.
Arnd
next prev parent reply other threads:[~2023-10-02 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 18:37 [PATCH v5 0/3] dmaengine: fsl_edma: add trace and debugfs support Frank Li
2023-10-02 18:37 ` [PATCH v5 1/3] debugfs_create_regset32() support 8/16 bit width registers Frank Li
2023-10-02 18:55 ` Arnd Bergmann
2023-10-02 19:07 ` Frank Li
2023-10-02 19:39 ` Arnd Bergmann [this message]
2023-10-02 18:37 ` [PATCH v5 2/3] dmaengine: fsl-emda: add debugfs support Frank Li
2023-10-02 18:37 ` [PATCH v5 3/3] dmaengine: fsl-edma: add trace event support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77c827ac-06a3-44fc-97ff-45db82ac0206@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Frank.li@nxp.com \
--cc=bhe@redhat.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox