DMA Engine development
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Frank Pavlic <f.pavlic@kunbus.de>,
	Martin Sperl <kernel@martin.sperl.org>,
	Florian Meier <florian.meier@koalo.de>,
	dmaengine@vger.kernel.org, Eric Anholt <eric@anholt.net>,
	linux-rpi-kernel@lists.infradead.org,
	Vinod Koul <vkoul@kernel.org>
Subject: [5/5] dmaengine: bcm2835: Remove dead code
Date: Fri, 28 Dec 2018 14:26:00 +0100 (CET)	[thread overview]
Message-ID: <782551991.176737.1546003560746@email.ionos.de> (raw)

Hi Lukas,

> Lukas Wunner <lukas@wunner.de> hat am 22. Dezember 2018 um 08:28 geschrieben:
> 
> 
> The BCM2835 DMA driver deletes a channel from a list upon termination
> without having added it to a list first.  Moreover that operation is
> protected by a spinlock which isn't taken anywhere else.  These appear
> to be remnants of an older version of the driver which accidentally
> got mainlined.  Remove the dead code.
> 
> While at it remove an outdated comment claiming the driver only supports
> cyclic transactions.  The driver has been supporting other transaction
> types for more than two years.
>

the fact that your mixing two different changes in one patch results in a very general subject.

Please split this up and give them more specific subject lines.

Thanks Stefan

             reply	other threads:[~2018-12-28 13:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-28 13:26 Stefan Wahren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-08 17:09 [5/5] dmaengine: bcm2835: Remove dead code Vinod Koul
2019-01-08 14:18 Lukas Wunner
2019-01-07  8:28 Vinod Koul
2018-12-28 15:27 Stefan Wahren
2018-12-28 13:55 Lukas Wunner
2018-12-22  7:28 Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=782551991.176737.1546003560746@email.ionos.de \
    --to=stefan.wahren@i2se.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=f.pavlic@kunbus.de \
    --cc=florian.meier@koalo.de \
    --cc=kernel@martin.sperl.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=lukas@wunner.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox