From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Sheetal ." <sheetal@nvidia.com>,
vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
ldewangan@nvidia.com
Subject: Re: [PATCH 1/2] dt-bindings: Document Tegra264 ADMA support
Date: Thu, 8 May 2025 14:47:11 +0200 [thread overview]
Message-ID: <7a6e46ea-bc8f-4e4e-ba74-e01c977f25d5@kernel.org> (raw)
In-Reply-To: <20250508123520.973675-2-sheetal@nvidia.com>
On 08/05/2025 14:35, Sheetal . wrote:
> From: Sheetal <sheetal@nvidia.com>
>
> Add Tegra264 ADMA support to the device tree bindings documentation.
> The Tegra264 ADMA hardware supports 64 DMA channels and requires
> specific register configurations.
>
> The binding maintains compatibility with existing Tegra platforms
> while adding support for Tegra264-specific features.
This is confusing sentence, because you did not make anything compatible
there. Drop it.
>
> Signed-off-by: Sheetal <sheetal@nvidia.com>
> ---
> Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml
> index d3f8c269916c..d204be46b90e 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra210-adma.yaml
> @@ -19,6 +19,7 @@ properties:
> - enum:
> - nvidia,tegra210-adma
> - nvidia,tegra186-adma
> + - nvidia,tegra264-adma
This is incomplete, missing constraints. Read *ENTIRE* binding, not top
25 lines only.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-08 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 12:35 [PATCH 0/2] Add Tegra264 support in ADMA driver Sheetal .
2025-05-08 12:35 ` [PATCH 1/2] dt-bindings: Document Tegra264 ADMA support Sheetal .
2025-05-08 12:47 ` Krzysztof Kozlowski [this message]
2025-05-08 12:35 ` [PATCH 2/2] dmaengine: tegra210-adma: Add Tegra264 support Sheetal .
2025-05-08 12:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a6e46ea-bc8f-4e4e-ba74-e01c977f25d5@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sheetal@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).