From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D1BCCA479 for ; Mon, 18 Jul 2022 15:56:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235201AbiGRP4v (ORCPT ); Mon, 18 Jul 2022 11:56:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235076AbiGRP4u (ORCPT ); Mon, 18 Jul 2022 11:56:50 -0400 X-Greylist: delayed 2640 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 18 Jul 2022 08:56:48 PDT Received: from imap4.hz.codethink.co.uk (imap4.hz.codethink.co.uk [188.40.203.114]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E70CA2A41F; Mon, 18 Jul 2022 08:56:48 -0700 (PDT) Received: from [167.98.27.226] (helo=[10.35.4.171]) by imap4.hz.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1oDSQ9-002C9w-8q; Mon, 18 Jul 2022 16:12:29 +0100 Message-ID: <7c68e645-efd7-c48c-77aa-9aa607c77033@codethink.co.uk> Date: Mon, 18 Jul 2022 16:12:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 03/13] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts Content-Language: en-GB To: Conor Dooley , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Thierry Reding , Sam Ravnborg , Eugeniy Paltsev , Vinod Koul , Serge Semin , Daniel Lezcano , Palmer Dabbelt , Palmer Dabbelt Cc: Paul Walmsley , Albert Ou , Conor Dooley , Masahiro Yamada , Damien Le Moal , Geert Uytterhoeven , Niklas Cassel , Dillon Min , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-riscv@lists.infradead.org, Rob Herring References: <20220705215213.1802496-1-mail@conchuod.ie> <20220705215213.1802496-4-mail@conchuod.ie> From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <20220705215213.1802496-4-mail@conchuod.ie> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 05/07/2022 22:52, Conor Dooley wrote: > From: Conor Dooley > > The Canaan k210 apparently has a Sysnopsys Designware AXI DMA > controller, but according to the documentation & devicetree it has 6 > interrupts rather than the standard one. Support the 6 interrupt > configuration by unconditionally extending the binding to a maximum of > 8 per-channel interrupts thereby matching the number of possible > channels. I think you can still configure it to produce a single interrupt even if there are per-channel interrupts available. This is from my reading of the driver a little while ago so may not be totally correct now. Having per-channel irqs might be useful in the future, but as above I think it'll require the driver to be updated to do it (and possibly some sort of detection) > Link: https://canaan-creative.com/wp-content/uploads/2020/03/kendryte_standalone_programming_guide_20190311144158_en.pdf #Page 51 > Reviewed-by: Serge Semin > Reviewed-by: Rob Herring > Signed-off-by: Conor Dooley > --- > .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > index 4324a94b26b2..67aa7bb6d36a 100644 > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > @@ -34,7 +34,12 @@ properties: > - const: axidma_apb_regs > > interrupts: > - maxItems: 1 > + description: > + If the IP-core synthesis parameter DMAX_INTR_IO_TYPE is set to 1, this > + will be per-channel interrupts. Otherwise, this is a single combined IRQ > + for all channels. > + minItems: 1 > + maxItems: 8 > > clocks: > items: -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html