Re: [PATCH v6 2/2] dt-bindings: dma: HiSilicon: Add bindings for HiSilicon Ascend sdma

["guomengqi (A)" <guomengqi3@huawei.com>]

在 2023/10/27 0:55, Rob Herring 写道:
> On Thu, Oct 26, 2023 at 03:25:49PM +0800, Guo Mengqi wrote:
>> Add device-tree binding documentation for sdma hardware on
>> HiSilicon Ascend SoC families.
>>
>> Signed-off-by: Guo Mengqi <guomengqi3@huawei.com>
>> ---
> This is where you explain any expected failure. Resending the same patch
> with the same failure again is not a great strategy. The patch needs to
> stand on its own and not rely on some explanation in a prior version.

OK, will do this next time. I was eager to see whether those kernel 
build warnings are fixed, so sent the new patch quickly.

>>   .../bindings/dma/hisilicon,ascend-sdma.yaml   | 73 +++++++++++++++++++
>>   1 file changed, 73 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> I had missed that pasid-num-bits and dma-can-stall are IOMMU consumer
> properties. (We really should have prefixed them with 'iommu'.) I've now
> added them to dtschema which should fix the warning.

They do look a little confusing.

Thanks.

-Mengqi

> Rob
>
> .