From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux PM <linux-pm@vger.kernel.org>, dmaengine@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Brian Norris <briannorris@chromium.org>,
Vinod Koul <vkoul@kernel.org>
Subject: [RESEND][PATCH v1] dmaengine: sh: Discard pm_runtime_put() return value
Date: Thu, 08 Jan 2026 16:28:13 +0100 [thread overview]
Message-ID: <8633556.T7Z3S40VBb@rafael.j.wysocki> (raw)
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Clobbering an error value to be returned from shdma_tx_submit() with
a pm_runtime_put() return value is not particularly useful, especially
if the latter is 0, so stop doing that.
This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
This is requisite for converting pm_runtime_put() into a void function.
If you decide to pick it up, please let me know.
Otherwise, an ACK or equivalent will be appreciated, but also the lack
of specific criticism will be eventually regarded as consent.
Originally posted here:
https://lore.kernel.org/linux-pm/9626129.rMLUfLXkoz@rafael.j.wysocki/
---
drivers/dma/sh/shdma-base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/dma/sh/shdma-base.c
+++ b/drivers/dma/sh/shdma-base.c
@@ -143,7 +143,7 @@ static dma_cookie_t shdma_tx_submit(stru
}
schan->pm_state = SHDMA_PM_ESTABLISHED;
- ret = pm_runtime_put(schan->dev);
+ pm_runtime_put(schan->dev);
spin_unlock_irq(&schan->chan_lock);
return ret;
next reply other threads:[~2026-01-08 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 15:28 Rafael J. Wysocki [this message]
2026-01-09 2:42 ` [RESEND][PATCH v1] dmaengine: sh: Discard pm_runtime_put() return value Vinod Koul
2026-01-09 12:15 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8633556.T7Z3S40VBb@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=briannorris@chromium.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox