From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: dan.j.williams@intel.com, vkoul@kernel.org, ldewangan@nvidia.com,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [3/6] dma: tegra: fix incorrect case of DMA
Date: Wed, 07 Nov 2018 08:27:50 +0000 [thread overview]
Message-ID: <86716993f44e30721379118e31c681a1@codethink.co.uk> (raw)
On 2018-11-06 13:14, Dmitry Osipenko wrote:
> On 31.10.2018 19:03, Ben Dooks wrote:
>> The use of Dma is annoying, since it is an acronym so should be all
>> upper case. Fix this throughout the driver.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> drivers/dma/tegra20-apb-dma.c | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/dma/tegra20-apb-dma.c
>> b/drivers/dma/tegra20-apb-dma.c
>> index adfd918baedc..4f7d1e576d03 100644
>> --- a/drivers/dma/tegra20-apb-dma.c
>> +++ b/drivers/dma/tegra20-apb-dma.c
>> @@ -146,7 +146,7 @@ struct tegra_dma_channel_regs {
>> };
>>
>> /*
>> - * tegra_dma_sg_req: Dma request details to configure hardware. This
>> + * tegra_dma_sg_req: DMA request details to configure hardware. This
>> * contains the details for one transfer to configure DMA hw.
>> * The client's request for data transfer can be broken into multiple
>> * sub-transfer as per requester details and hw support.
>> @@ -574,7 +574,7 @@ static bool handle_continuous_head_request(struct
>> tegra_dma_channel *tdc,
>> struct tegra_dma_sg_req *hsgreq = NULL;
>>
>> if (list_empty(&tdc->pending_sg_req)) {
>> - dev_err(tdc2dev(tdc), "Dma is running without req\n");
>> + dev_err(tdc2dev(tdc), "DMA is running without req\n");
>> tegra_dma_stop(tdc);
>> return false;
>> }
>> @@ -922,7 +922,7 @@ static int get_transfer_param(struct
>> tegra_dma_channel *tdc,
>> return 0;
>>
>> default:
>> - dev_err(tdc2dev(tdc), "Dma direction is not supported\n");
>> + dev_err(tdc2dev(tdc), "DMA direction is not supported\n");
>> return -EINVAL;
>> }
>> return -EINVAL;
>> @@ -988,7 +988,7 @@ static struct dma_async_tx_descriptor
>> *tegra_dma_prep_slave_sg(
>>
>> dma_desc = tegra_dma_desc_get(tdc);
>> if (!dma_desc) {
>> - dev_err(tdc2dev(tdc), "Dma descriptors not available\n");
>> + dev_err(tdc2dev(tdc), "DMA descriptors not available\n");
>> return NULL;
>> }
>> INIT_LIST_HEAD(&dma_desc->tx_list);
>> @@ -1008,14 +1008,14 @@ static struct dma_async_tx_descriptor
>> *tegra_dma_prep_slave_sg(
>> if ((len & 3) || (mem & 3) ||
>> (len > tdc->tdma->chip_data->max_dma_count)) {
>> dev_err(tdc2dev(tdc),
>> - "Dma length/memory address is not supported\n");
>> + "DMA length/memory address is not supported\n");
>> tegra_dma_desc_put(tdc, dma_desc);
>> return NULL;
>> }
>>
>> sg_req = tegra_dma_sg_req_get(tdc);
>> if (!sg_req) {
>> - dev_err(tdc2dev(tdc), "Dma sg-req not available\n");
>> + dev_err(tdc2dev(tdc), "DMA sg-req not available\n");
>> tegra_dma_desc_put(tdc, dma_desc);
>> return NULL;
>> }
>> @@ -1147,7 +1147,7 @@ static struct dma_async_tx_descriptor
>> *tegra_dma_prep_dma_cyclic(
>> while (remain_len) {
>> sg_req = tegra_dma_sg_req_get(tdc);
>> if (!sg_req) {
>> - dev_err(tdc2dev(tdc), "Dma sg-req not available\n");
>> + dev_err(tdc2dev(tdc), "DMA sg-req not available\n");
>> tegra_dma_desc_put(tdc, dma_desc);
>> return NULL;
>> }
>>
>
>
> There is also:
>
> if (!tdc->config_init) {
> dev_err(tdc2dev(tdc), "dma channel is not configured\n");
> return NULL;
> }
>
> that could be fixed too and with that:
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Thanks, fixed for next patch series.
next reply other threads:[~2018-11-07 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 8:27 Ben Dooks [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-07 12:04 [3/6] dma: tegra: fix incorrect case of DMA Dmitry Osipenko
2018-11-06 13:14 Dmitry Osipenko
2018-10-31 16:03 Ben Dooks
2018-10-12 9:44 Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86716993f44e30721379118e31c681a1@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=dan.j.williams@intel.com \
--cc=digetx@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).