* [12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call
@ 2019-02-11 13:30 Felipe Balbi
0 siblings, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2019-02-11 13:30 UTC (permalink / raw)
To: Christoph Hellwig
Cc: John Crispin, Vinod Koul, Dmitry Tarnyagin, Nicolas Ferre,
Sudip Mukherjee, linux-mips, linux-kernel, dmaengine, netdev,
linux-usb, linux-fbdev, alsa-devel, iommu
Hi,
Christoph Hellwig <hch@lst.de> writes:
> On Fri, Feb 01, 2019 at 05:10:26PM +0100, Christoph Hellwig wrote:
>> On Fri, Feb 01, 2019 at 03:19:41PM +0200, Felipe Balbi wrote:
>> > Christoph Hellwig <hch@lst.de> writes:
>> >
>> > > dma_map_single already transfers ownership to the device.
>> > >
>> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
>> >
>> > Do you want me to take the USB bits or will you take the entire series?
>> > In case you're taking the entire series:
>>
>> If you want to take the USB feel free. I just want most of this in
>> this merge window if possible.
>
> I didn't see in the USB tree yet, so please let me know if you want to
> take it.
sorry for the delay, just took it to my tree.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call
@ 2019-02-11 13:12 Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2019-02-11 13:12 UTC (permalink / raw)
To: Felipe Balbi
Cc: Christoph Hellwig, John Crispin, Vinod Koul, Dmitry Tarnyagin,
Nicolas Ferre, Sudip Mukherjee, linux-mips, linux-kernel,
dmaengine, netdev, linux-usb, linux-fbdev, alsa-devel, iommu
On Fri, Feb 01, 2019 at 05:10:26PM +0100, Christoph Hellwig wrote:
> On Fri, Feb 01, 2019 at 03:19:41PM +0200, Felipe Balbi wrote:
> > Christoph Hellwig <hch@lst.de> writes:
> >
> > > dma_map_single already transfers ownership to the device.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Do you want me to take the USB bits or will you take the entire series?
> > In case you're taking the entire series:
>
> If you want to take the USB feel free. I just want most of this in
> this merge window if possible.
I didn't see in the USB tree yet, so please let me know if you want to
take it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call
@ 2019-02-01 16:10 Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2019-02-01 16:10 UTC (permalink / raw)
To: Felipe Balbi
Cc: Christoph Hellwig, John Crispin, Vinod Koul, Dmitry Tarnyagin,
Nicolas Ferre, Sudip Mukherjee, linux-mips, linux-kernel,
dmaengine, netdev, linux-usb, linux-fbdev, alsa-devel, iommu
On Fri, Feb 01, 2019 at 03:19:41PM +0200, Felipe Balbi wrote:
> Christoph Hellwig <hch@lst.de> writes:
>
> > dma_map_single already transfers ownership to the device.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Do you want me to take the USB bits or will you take the entire series?
> In case you're taking the entire series:
If you want to take the USB feel free. I just want most of this in
this merge window if possible.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call
@ 2019-02-01 13:19 Felipe Balbi
0 siblings, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2019-02-01 13:19 UTC (permalink / raw)
To: Christoph Hellwig, John Crispin, Vinod Koul, Dmitry Tarnyagin,
Nicolas Ferre, Sudip Mukherjee, linux-mips, linux-kernel,
dmaengine, netdev, linux-usb, linux-fbdev, alsa-devel
Cc: iommu
Christoph Hellwig <hch@lst.de> writes:
> dma_map_single already transfers ownership to the device.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Do you want me to take the USB bits or will you take the entire series?
In case you're taking the entire series:
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> ---
> drivers/usb/gadget/udc/fotg210-udc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c
> index bc6abaea907d..fe9cf415f2f1 100644
> --- a/drivers/usb/gadget/udc/fotg210-udc.c
> +++ b/drivers/usb/gadget/udc/fotg210-udc.c
> @@ -356,10 +356,6 @@ static void fotg210_start_dma(struct fotg210_ep *ep,
> return;
> }
>
> - dma_sync_single_for_device(NULL, d, length,
> - ep->dir_in ? DMA_TO_DEVICE :
> - DMA_FROM_DEVICE);
> -
> fotg210_enable_dma(ep, d, length);
>
> /* check if dma is done */
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call
@ 2019-02-01 8:47 Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2019-02-01 8:47 UTC (permalink / raw)
To: John Crispin, Vinod Koul, Dmitry Tarnyagin, Nicolas Ferre,
Sudip Mukherjee, Felipe Balbi, linux-mips, linux-kernel,
dmaengine, netdev, linux-usb, linux-fbdev, alsa-devel
Cc: iommu
dma_map_single already transfers ownership to the device.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/usb/gadget/udc/fotg210-udc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c
index bc6abaea907d..fe9cf415f2f1 100644
--- a/drivers/usb/gadget/udc/fotg210-udc.c
+++ b/drivers/usb/gadget/udc/fotg210-udc.c
@@ -356,10 +356,6 @@ static void fotg210_start_dma(struct fotg210_ep *ep,
return;
}
- dma_sync_single_for_device(NULL, d, length,
- ep->dir_in ? DMA_TO_DEVICE :
- DMA_FROM_DEVICE);
-
fotg210_enable_dma(ep, d, length);
/* check if dma is done */
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-11 13:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-11 13:30 [12/18] fotg210-udc: remove a bogus dma_sync_single_for_device call Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2019-02-11 13:12 Christoph Hellwig
2019-02-01 16:10 Christoph Hellwig
2019-02-01 13:19 Felipe Balbi
2019-02-01 8:47 Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).