From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DD6C54EE9 for ; Sat, 17 Sep 2022 09:17:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbiIQJR2 (ORCPT ); Sat, 17 Sep 2022 05:17:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbiIQJR1 (ORCPT ); Sat, 17 Sep 2022 05:17:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9618F45980; Sat, 17 Sep 2022 02:17:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2FDD661325; Sat, 17 Sep 2022 09:17:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79D24C433D6; Sat, 17 Sep 2022 09:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663406244; bh=PmSUO1q26n8MEHPMpIYDhyZ/koyt1KmDorHa9IO2m/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HA5DdpxrG2ueLj2osB/uvUxmx4+XW5pRkJWkoiyoAXPNlifZ41iDMJ0rSlMVAlY+y fDj++YypuEDBTFhddLNqYs5BPW734ykOeV6rQ7jNfWyJSu8a8YntqFB+gXNzwLdMRx XiBGmw5oFRpNn0jpUAzSwj0dAV0rwEEkSrBsaZT1zL7tvgA3GYqKt2wWJ6Bz9AxLh9 VuPLckmtgNiuBPR/X1g97i7b/wmqq22dRr8L1nIKnAg1qbSuUKHqkvea7MWOAR9LrU wrCv2491ajVxmY16LHkli/YpW7Mzs1s1nVwLvmpnEzpUO9UNxx0sMHksDQYvYLKonq RVX7TpWvNAh/w== Received: from 185-176-101-241.host.sccbroadband.ie ([185.176.101.241] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oZTww-00AlgE-0k; Sat, 17 Sep 2022 10:17:22 +0100 Date: Sat, 17 Sep 2022 10:17:19 +0100 Message-ID: <87pmful5r4.wl-maz@kernel.org> From: Marc Zyngier To: Janne Grunau Cc: asahi@lists.linux.dev, Mark Kettenis , Alyssa Rosenzweig , Hector Martin , Krzysztof Kozlowski , Martin =?UTF-8?B?UG92acWhZXI=?= , Rob Herring , Sven Peter , Thomas Gleixner , Vinod Koul , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 00/10] Apple M1 Pro/Max/Ultra device trees In-Reply-To: <20220916142550.269905-1-j@jannau.net> References: <20220916142550.269905-1-j@jannau.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.176.101.241 X-SA-Exim-Rcpt-To: j@jannau.net, asahi@lists.linux.dev, kettenis@openbsd.org, alyssa@rosenzweig.io, marcan@marcan.st, krzysztof.kozlowski+dt@linaro.org, povik+lin@cutebit.org, robh+dt@kernel.org, sven@svenpeter.dev, tglx@linutronix.de, vkoul@kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Fri, 16 Sep 2022 15:25:40 +0100, Janne Grunau wrote: > > Hej, > > this series contains device trees for Apple's M1 Pro, Max and Ultra SoCs > and devices based on these SoCs. > > Quoting from the main commit: > > | These SoCs are found in Apple devices with M1 Pro (t6000), M1 Max > | (t6001) and M1 Ultra (t6002). > | > | t6000 is a cut-down version of t6001, so the former just includes the > | latter and disables the missing bits (This is currently just one PMGR > | node and all of its domains. > | > | t6002 is two connected t6001 dies. The implementation seems to use > | t6001 with blocks disabled (mostly on the second die). MMIO addresses on > | the second die have a constant offset. The interrupt controller is > | multi-die aware. This setup can be represented in the device tree with > | two top level "soc" nodes. The MMIO offset is applied via "ranges" and > | devices are included with preproceesor macros to make the node labels > | unique and to specify the die number for the interrupt definition. > | > | Device nodes are distributed over dtsi files based on whether they are > | present on both dies or just on the first die. The only execption is the > | NVMe controller which resides on the second die. Its nodes are in a > | separate file. > > This series depends for full functionality on t600x dart support (latest > version at > https://lore.kernel.org/linux-iommu/20220916094152.87137-1-j@jannau.net/T/#t > expected to be picked up for 6.1). This is the usual device tree / > driver changes runtime dependency. > > Even with the t6000-dart support t600x devices are not terribly useful > in upstream. There is no input device support. The laptop's keyboard > and touchpad are missing SPI and HID over SPI drivers. The dwc3 > USB-C ports are not yet added since they require special handling > after disconnect. The PCIe based USB xhci controller in the Mac Studio > requires firmware downloaded in a similar way as USB_XHCI_PCI_RENESAS. > > To simplify dependency handling this series carries mostly identical > device tree additions for M1 and M1 Pro/Max/Ultra as part of the in > development audio support. > > The series passes dtbs_check with 3 additional dt bindings changes: > - "dt-bindings: apple,aic: Fix required item "apple,fiq-index" in > affinity description" (merged as da3b1c294d47 in Linus' repo) > - "ASoC: Add Apple MCA I2S transceiver bindings" (6ed462d1c11675) > in sound/for-next > - "dt-bindings: iommu: dart: add t6000 compatible" > https://lore.kernel.org/linux-iommu/20220901012519.7167-2-j@jannau.net/ > > New bindings passes dt_binding_check. For the whole series: Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.