From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683FA2C15BB for ; Tue, 9 Jun 2026 10:34:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781001300; cv=none; b=AVHgoEMAB4DNEcv+uSOc7m9ojUvzLwxlV5PjfyKf+/jqPSXm9ljrKVPGU2iM5jwnDCDJTHNL1p5cNmLWdtbegSTXvnpxcEmE/TEq6LguDBBqq6Yixw50OA4hA6CFrRL1FRIC1rnSrCzejaXoTAArga1vM7cc1QKAy4/9HtQORRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781001300; c=relaxed/simple; bh=JtA0re8kidO3gfQkDn8ChGhRgxdcG02cRmDUFQXfcrI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sr3uwvhDMQK1S3eul/Jt+amNwMdLKm2FsL/nu/jl4+yD5268rSTmI0V2loG/CVaAFSluMsPBgDWCOQBVabp55O6OZh442XYPKJQJWLHjOgnUpxnxVhn314rU0TbvCk5/SJaSNlCH5ohAZFrTtvz+88EAE3KXMHI8rRLVMa2YOfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gJvZHNzS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OlozP4Y/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gJvZHNzS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OlozP4Y/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6599vJjt1800728 for ; Tue, 9 Jun 2026 10:34:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mPr84Bdv3vOiH6osuLFjd2Cuwh2MgJdCXKl5w0JclkE=; b=gJvZHNzSRI49RMSG 7NfTKi7GFGAwCQ6LJNWNjXqHMvLvdSyRQCgqkxgjidq+JZBsGFI5805Z4wRaKvP1 nIhPhzAmQPvyomeyJI0tDyNt/i87Q9hRA+wT+p2NE5GgBTlWvIMWB3STQBO0jkfd QA1gCjO1DxKoNk+UN4Me71NLjIgwh+D7X+q/PFW0BqwLbPXRGgjJoESKcAXgRVnS BxX590lG9/lfzviTH4JA0qJurpB7CN/rHBX4p+YXHYfPx0pzqDVOIddVC59xSXSM 3B8oD7C5M04OgTvIosZfNeNEBq/k91iXUCul0FmaEIKLVw0jY/+Q+nu2NFGX6wzt cILigA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epenr8pgk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 10:34:58 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2bf2bc4371bso44013065ad.1 for ; Tue, 09 Jun 2026 03:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781001298; x=1781606098; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mPr84Bdv3vOiH6osuLFjd2Cuwh2MgJdCXKl5w0JclkE=; b=OlozP4Y/ah00jnADkGG1tUEHnHuvL+nQBeYidQRl1E6GYKQ2bnUTc6KrAVw6srjceE VzvDBJrtI8TCKemA2xpmEqxs7uI6hGBRpTrVbFNkLUpNpK8SFxSyX/fRwmij0Dur7kQ1 DvBBZSrEgj3pMyVmd+VLH9BBALPxItuFDyKQmIetvimQaBwqUnkFWgjgEhjV6pX//HxA hEkJXH3xBqsQMdvjW2yTmQf51XqBSjUP9mxCyu22rgkLNK3GHgFfdYjo1QzcJDbBRSX9 1/HKNGCrL2ToEs41cGGJdaABTWzU6PmoKGmYqG2xk+APJsMezm+XhUnaPpdKq8DG06QY nlIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781001298; x=1781606098; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mPr84Bdv3vOiH6osuLFjd2Cuwh2MgJdCXKl5w0JclkE=; b=eFEt2bWZPfn5xPs3I7FBb+jNKwxLFjsSbdOtnBONU5u4TverKQjHO7iaXTKuZxBV6s evjAlYlh7j9mKACcskKop+ryxWoo1Dqh1LJKxwufOYDWGLXRXj0+S81vqQZApfv1745m rOB/lT9pEJ+q32UEyybdlH57Zv552ffd22W25c6aGEk5gfSaer48Dy+PfXuYn0By9xxP i/LBadh2Hi0Uxgk2G1iXdFKmowWC/41li4Pf8IYG3ftG4eSvuDR6cO+Mxffr2V1FOdY3 Q509VvS/ju7k0CW+n2rbsBdKDT3wTBUrPzQLQUsOAxQ+zGtCqHv6Rc28fpmSWX1tLDPA yhHQ== X-Forwarded-Encrypted: i=1; AFNElJ9PFfv21oUVIeFpJ+yuAfBlBZdfA9EWFEUtWieLIhkmm3IvsJ+5XwEdIafkwiznMeDNzHZtliL/ijg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5lYjjSJNYZk1Kffb8Jcotf8+1y74bSynfSAIY6zblBq2iyFq3 FDzQc3lIzmB37TqbQ9sgThurjZ7KQP2ZVcUHrScOViZxKtpXtyCeJ4ab59+/8N/HkecjCf5GPzo 9eFzRIc0shlN5c7E7huw0PbthY5tv8rKSOv8LDZV6ntvxKIY8J9Q/F87G3t8wr5g= X-Gm-Gg: Acq92OGMTJZA0hwjaeWABsEZHIxdZQG6S53uQ6u7cQyBRmppqibIFvRaeb2RZlkvpJ0 SV9MT5vXte4aJnlJHe8+I/ToKIMqMZZlEkQ5qx2jOQ0E4nB+UOp/tUEmbAOvTvxixvCqxeOIiSK NywwfJd4Hofq8PWH3fhzTkkSkB77sMigOQIGGYFupCRwiekQgoGSN6/wkbNCX6wNnjbNv5yzprI us8X5sdZCxkZsFrAAHbPP1NyqFzkHVZq56tft+SWigWNk5GgqKaMCdt+vjfFO49aBizpF0XiDTG R3Kgrnq2bk8ltxzX6xsUSuPI5DYNhtQmwRsVhrRq6peGhPJW5gocTZCsVhlXt3jYH1pFcbQR0Bj 4Wbbz3+EjtAIuI03zHawEj+/XLjIR+0dbTeUsd+CxNm6MTFibQMrKZto= X-Received: by 2002:a17:903:94d:b0:2c0:d94f:50c7 with SMTP id d9443c01a7336-2c1ec508177mr177538895ad.7.1781001297853; Tue, 09 Jun 2026 03:34:57 -0700 (PDT) X-Received: by 2002:a17:903:94d:b0:2c0:d94f:50c7 with SMTP id d9443c01a7336-2c1ec508177mr177538505ad.7.1781001297298; Tue, 09 Jun 2026 03:34:57 -0700 (PDT) Received: from [10.152.201.53] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d042sm217458055ad.60.2026.06.09.03.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 03:34:56 -0700 (PDT) Message-ID: <89a95a6f-1dce-4141-9b7c-12d7ab6bc0af@oss.qualcomm.com> Date: Tue, 9 Jun 2026 16:04:52 +0530 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] dma: qcom: bam_dma: Fix command element mask field for BAM v1.6.0+ To: Dmitry Baryshkov Cc: Varadarajan Narayanan , Vinod Koul , Frank Li , Abhishek Sahu , mani@kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, lakshmi.d@oss.qualcomm.com References: <20260514-bam-fix-v5-1-58f6edb34969@oss.qualcomm.com> <5c24a3f3-a4c0-43ec-9653-bc374a9c5e22@oss.qualcomm.com> <6qkgzmrr3oxzj47so4jqw6gk6stzjkxbnaflajk5zw5fgf65cn@yj3d55p5b7do> Content-Language: en-US From: Md Sadre Alam In-Reply-To: <6qkgzmrr3oxzj47so4jqw6gk6stzjkxbnaflajk5zw5fgf65cn@yj3d55p5b7do> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 8idFg3viYVZ8YlksNK-5i9ekPKP6wiqN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5OSBTYWx0ZWRfX2ouRjVplddMV 2inSaEtL0LX18T+YyKFWiHsEgKLLLuBxFsQFFa9KoQ/sR0YqyabJ9sTfomMcIJAXgDr/ARmtNo7 OJSfrGTtPcQJh+B0FwMk/3LmHPZCOGpuU/L6p1RJJOMbg8lApYzlCtHiH7f+GA0Tjda4lTsJXHh HTWfU7MmwIOHKgArTGElpqbexQHFIbSEzVpD+o8z4Wxi5DIZ9hsI695q4eiBkFcEDiE0ifG3PZO ydUzlVXX+C+WLHyoX/sP1Wl/BqLhf75ZaDozZAJ/J60qcbfdh8SgVlx0HkXB0aMQk+pyMjeS56t Pbj/MWCsHk3MX8zxPlxh4Eubpxmi7UBX9Qt0OVgufdHqF3Gp8kwWNcixWtPteqw9QOTsZO3SVJs TSiX4SHXyP3dQNxCJzK9wc969u/zFl5yW/QqHHqkLJJxtsWHN0DDK45d2tjiWjiG0CPq5AEDXEy EDV0ruBZhl+NGnAtIDw== X-Authority-Analysis: v=2.4 cv=NKPlPU6g c=1 sm=1 tr=0 ts=6a27ec52 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=I2Tm49LE0oniHcX1gG8A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: 8idFg3viYVZ8YlksNK-5i9ekPKP6wiqN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090099 Hi, On 6/8/2026 11:33 AM, Dmitry Baryshkov wrote: > On Mon, Jun 08, 2026 at 11:20:01AM +0530, Md Sadre Alam wrote: >> Hi, >> >> On 6/4/2026 4:15 PM, Varadarajan Narayanan wrote: >>> On Tue, May 19, 2026 at 11:01:51PM +0530, Vinod Koul wrote: >>>> On 14-05-26, 12:09, Varadarajan Narayanan wrote: >>>>> From: Md Sadre Alam >>>>> >>>>> BAM version 1.6.0 and later changed the behavior of the mask field in >>>>> command elements for read operations. In newer BAM versions, the mask >>>>> field for read commands contains the upper 4 bits of the destination >>>>> address to support 36-bit addressing, while for write commands it >>>>> continues to function as a traditional write mask. >>>> >>>> But this changes behaviour for all versions. What happens to folks on older >>>> versions, wont this break for them, if not what am I missing >> >> It will not have any impact on older version of BAM controller. Konrad also >> had a similar concern. Please refer to [1] >> >> [1] https://lore.kernel.org/linux-arm-msm/2394e63f-1df7-764e-5489-3567065707a1@quicinc.com/ > > So, you got this question once, have resent the patches, but didn't > guess that there will be the similar question from other reviewers? > > Usually a question means that the commit needs to be improved. Adding a > simple "Previously this field was ignored for read commands" would have > saved you from futher questions. Will update the commit message and post the new version. Thanks, Alam.