DMA Engine development
 help / color / mirror / Atom feed
From: Lizhi Hou <lizhi.hou@amd.com>
To: Minjie Du <duminjie@vivo.com>, Brian Xu <brian.xu@amd.com>,
	"Raj Kumar Rampelli" <raj.kumar.rampelli@amd.com>,
	Vinod Koul <vkoul@kernel.org>,
	Michal Simek <michal.simek@amd.com>,
	"open list:XILINX XDMA DRIVER" <dmaengine@vger.kernel.org>,
	"moderated list:ARM/ZYNQ ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Cc: <opensource.kernel@vivo.com>
Subject: Re: [PATCH v1] drivers: xilinx: Fix Judgment of the return value of the devm_ioremap_resource function
Date: Wed, 5 Jul 2023 09:47:41 -0700	[thread overview]
Message-ID: <8b5c6d42-c1a8-81a3-5947-7a720501ef15@amd.com> (raw)
In-Reply-To: <20230704120458.11125-1-duminjie@vivo.com>

Hi Minjie,

There was a patch created for this. Please see

https://lore.kernel.org/all/20230217062652.172480-1-yangyingliang@huawei.com/


Thanks,

Lizhi

On 7/4/23 05:04, Minjie Du wrote:
> IS_ERR() fix devm_ioremap_resource function return judge.
> Could you help check it out?
> Thank you!
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>   drivers/dma/xilinx/xdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 93ee298d5..ad5ff6335 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
>   	}
>   
>   	reg_base = devm_ioremap_resource(&pdev->dev, res);
> -	if (!reg_base) {
> +	if (IS_ERR(reg_base)) {
>   		xdma_err(xdev, "ioremap failed");
>   		goto failed;
>   	}

      parent reply	other threads:[~2023-07-05 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 12:04 [PATCH v1] drivers: xilinx: Fix Judgment of the return value of the devm_ioremap_resource function Minjie Du
2023-07-04 12:15 ` Michal Simek
2023-07-05 16:47 ` Lizhi Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b5c6d42-c1a8-81a3-5947-7a720501ef15@amd.com \
    --to=lizhi.hou@amd.com \
    --cc=brian.xu@amd.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=duminjie@vivo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=opensource.kernel@vivo.com \
    --cc=raj.kumar.rampelli@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox