From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B60A426D20 for ; Fri, 15 May 2026 10:29:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778840943; cv=none; b=sRPNVJAXhfRVA4MhfYpbRQz0j8tJsh2CFPW6LsuhUgvNrM9fAFmA9buOxNQ7lijW8k2uVghP+5OjSOFA4fQw35ETYx5nwh5qhTCB950yHLLkWq4LSEiZwPIxQHKvFgibG7ds2pSzhT7hIqzIa0dH8nqeArE+Wi/kbsyub7o2egY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778840943; c=relaxed/simple; bh=LnYc4Uf6Zj7qgzTrWROWBK27v52kuP5FNB3OaImv/DU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CbffzB+1UpUulRCt5Ydl3Lgo6ISkRYDxr9imaTw40uyYJbVONKBn9Be9eoSAH8eVbb1iw0iQlL7iWRKj+h+nmqLCh9JTwL2RkJFNhF3vOOp4D9YwkXtvxjGB+gn4MM6RShNVSLnUjGbQd8AW3eAkgqRX4wI3EYdsSJ0bnIpZ6+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SZJao5xn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IzNX8VNS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SZJao5xn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IzNX8VNS" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F9HqoH1715145 for ; Fri, 15 May 2026 10:29:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y1RiNDXIBfcOkBMrHcP7edqinXmBvxHiwFxSxjAQBr4=; b=SZJao5xnlh5A2eTc f336zPMF1Hz9W9q7q1LzHyRnxPPovWF9WNoWlvz66GoblgOjmCOQ7NH/purQKU0/ 4Tqy5bcIqo5BPu3hrRKSxFwKek1cxaUDGHCLi4Fdt7weX0lz0n5xb3mTCBu9+nh7 W5uI5uebiD+h48fZ/W5pCrkMmHo+Ge/E7MVFU4jd2pXrfcVk+4Q62JDXEjeMWUyz x5UA3XzT1aV7kJwLS+RJjZW6XPux5+wVUr54NC44aQ7tI0SgflATpo1UkivAWAVA PXuNogpP0CCR+aVZIkOosnxXYCUqw2xKsMmkNfcnzaFtEzuDCKi7+NEOSbAgXHoW ScnGYA== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5tyxsmg7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 10:29:01 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-633dcda64cdso440739137.3 for ; Fri, 15 May 2026 03:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778840940; x=1779445740; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y1RiNDXIBfcOkBMrHcP7edqinXmBvxHiwFxSxjAQBr4=; b=IzNX8VNS/G9kqYeg0ff1MOSJsfCdIYX2XsTDUGrYYwj8/by0P7Ld4cHOo1B89l4eZq 35O/BcmX4NIiJIqDJdCZh/CBwFnQ9qMn5eEP/HZTPJZHZVv+awYI5Wp2K0FDNfkn/ki6 u0ietD1wPFstCDX1c9O7/2TL+4nlvd/m0JVgbrow18XhDJBIui0oU4VacmUVFjYegpg9 ldrUK8cTeE6y9mUeP+z2zwqBnqxnFEkfq/WKoB+x5BtHasSb/0NqZhvJ7gkBduAhLZGl vhNiKEGCsIPHvN2C2j+hrYs9rYZ2DEuhFxKvNcI1uPF2hJzXQrkZC0dgHMxrTODHYx3D UdQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778840940; x=1779445740; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y1RiNDXIBfcOkBMrHcP7edqinXmBvxHiwFxSxjAQBr4=; b=KmgnYeDEPrbS4I1UksVVqQKTZcjIOHvV+D962qu2ue3ccDvLLmcH/5DIJ/pv6u9soW IzD3KnAWlS6dW2B/HWccy3Kb3TFj2KbO9102Pe1BNDWbjTQY0agiKUAP9QIxYPCD72Bv bCqVDH7lQoP1rOxi12mtquwBlCGjxmBD+4r+c+u3XK/9QuP/rQd/8P3ro8I7wpLjguR7 SlkGHAtq75lPtEY7mp4rSJT2py1Ysg7pya99H9hKpitkXdo3WyT1CoTJvFeoug82DmyC RCu/4vqPBCjGd2gAGVl1O38q+edQE2WzkfkTZOyoNUf62KobryXTq0/XlY6071wSvzcm 8EJA== X-Forwarded-Encrypted: i=1; AFNElJ+RyhOE5zliW/yV8wAZmLlSZEv/nieSYOOZJdCIocjEtjkobDBM1xjnQ5QTFWq6jJanL9fYtIEJP20=@vger.kernel.org X-Gm-Message-State: AOJu0YyHp+5Hdi74bzlnuyi22DASIryjAd9c6UzhRGrIB86FI8RS2sQY 7CxWkOjctwiIUq1EmEVM6gbOVV7nm0tfKg1FwPPxGCqWo0xHCb08SaNr/vbfrhmbBirzhuW+/ub yGElzkCNWWpKtpWqTWrM4Yx4TmvvrbD0J3yIsXbiluhYHnQDeNqdMmho9PK121UU= X-Gm-Gg: Acq92OFz5c7+RYrQ0zk7wTBtQ8OheftlV5TAUe3bxwrrt8rrie3yGumZdq04M92/9HD Bx/Yedp2PSt90YqBYT1I/5x0Mqnm25rNa9bA7Y/W478y5e4L4KzKZu0Zbfii4nf6alnZwxKp0Fi 52z/FeMbTOnN0rbqa/3YzvPMXX+JIVedpjVs/9ilCn5SM+qF4yr07x11aPIw0vhiRK46xGw2/MZ 7ty3HQ9aZ7vyc3/fopcwNvqLAVVwJaYtdnIjvpXF4Jn6lawqb++XgA8KjTpYKw7flYKN0YKfhb7 pazEZgotorgGUmUTqEIiP+fmLmRpnYRLWtjCCm5aen9APBe/FOa9S+2faXkclTLr09yMaVsZ2Pw FIpWznsMI+JSrP4sm1+QIIxEQDUPF1U1U5kTQhTu1VmQ6bg4WOJ4sxPV8mJlNogvH2kt2I1GWef 2AZXo= X-Received: by 2002:a05:6102:3f0e:b0:635:3f36:e1c5 with SMTP id ada2fe7eead31-63a403a486amr577751137.8.1778840940590; Fri, 15 May 2026 03:29:00 -0700 (PDT) X-Received: by 2002:a05:6102:3f0e:b0:635:3f36:e1c5 with SMTP id ada2fe7eead31-63a403a486amr577732137.8.1778840940077; Fri, 15 May 2026 03:29:00 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4c29ea9sm204315766b.16.2026.05.15.03.28.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 03:28:59 -0700 (PDT) Message-ID: <8dfa0670-7605-497b-9d53-db9b4a8a3d8d@oss.qualcomm.com> Date: Fri, 15 May 2026 12:28:56 +0200 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support To: Kuldeep Singh , Thara Gopinath , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Frank Li , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org References: <20260515-shikra_qcrypto-v1-0-80f07b345c29@oss.qualcomm.com> <20260515-shikra_qcrypto-v1-3-80f07b345c29@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260515-shikra_qcrypto-v1-3-80f07b345c29@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dMWWXuZb c=1 sm=1 tr=0 ts=6a06f56d cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=Cp0X72Tp7Ho1uHa1MVsA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-ORIG-GUID: amuFHF-8YZRY7nbeBtTu5ikpHPRW6-HB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDEwNSBTYWx0ZWRfX/3GOC6eyuuCd M2fUq8zAPBLo6oLDe+jzgzSSldAEnoqC7JRWC7BjTOntav75bW7CAP4dFy04ZxFmaDP7rX+Gw8K 725NazGB8ieTo1XNjstscJa5EdKw3mOVbkkq9NhoxfmVWlp541sbtWEdodb8s40kfAsKUXGL7OE 6gkaNCPbL7SrIG0yhnXs5iJYWww64BP5ViN867RzwylIbrceq4inRNVEU+1lm5Px/J/Ag2XG/tE MqXA9kydYSBLJoL5rQGUvLUmzqygV4ynLL48vIKohVC8qApz04Xgu6l95OeVkJoMpAmeld11gsL 5NZAhPBMF8cTepi+X7hxRT7/CDkO5cM3OvzCqpk2iCjVIXmxnPXxWQjtsIHzzOw++QHC+EGmcPc uY/zfuJ3ODc3XU8gLcUWYC2c37MsIT/SW2eZWqcBE62cEAmek/G4BRQdBKdJalIk2/z5nK10I75 Nj1kPuLO+Q1MWef3a+A== X-Proofpoint-GUID: amuFHF-8YZRY7nbeBtTu5ikpHPRW6-HB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 clxscore=1011 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150105 On 5/14/26 9:23 PM, Kuldeep Singh wrote: > Add qcrypto and cryptobam support for shikra target. > > Signed-off-by: Kuldeep Singh > --- > arch/arm64/boot/dts/qcom/shikra.dtsi | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi > index 262c488add1e..dbac0e901d6e 100644 > --- a/arch/arm64/boot/dts/qcom/shikra.dtsi > +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi > @@ -541,6 +541,41 @@ config_noc: interconnect@1900000 { > #interconnect-cells = <2>; > }; > > + cryptobam: dma-controller@1b04000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0x0 0x01b04000 0x0 0x24000>; > + interrupts = ; > + #dma-cells = <1>; > + iommus = <&apps_smmu 0x84 0x0011>, > + <&apps_smmu 0x86 0x0011>, > + <&apps_smmu 0x92 0x0>, > + <&apps_smmu 0x94 0x0011>, > + <&apps_smmu 0x96 0x0011>, These two entries are logically the same (SID & ~mask) as the first two, does it still work if you remove them? > + <&apps_smmu 0x98 0x0001>, > + <&apps_smmu 0x9F 0x0>; Let's keep lowercase hex Konrad