From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50B1C433EF for ; Mon, 27 Jun 2022 13:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235463AbiF0NQk (ORCPT ); Mon, 27 Jun 2022 09:16:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235308AbiF0NQ1 (ORCPT ); Mon, 27 Jun 2022 09:16:27 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDE521055D; Mon, 27 Jun 2022 06:14:05 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LWp5x2xgmzhYnY; Mon, 27 Jun 2022 21:11:49 +0800 (CST) Received: from kwepemm600007.china.huawei.com (7.193.23.208) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 27 Jun 2022 21:14:03 +0800 Received: from [10.67.102.167] (10.67.102.167) by kwepemm600007.china.huawei.com (7.193.23.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 27 Jun 2022 21:14:02 +0800 Message-ID: <91566735-d576-9c3d-88f1-9e0f3bc94395@huawei.com> Date: Mon, 27 Jun 2022 21:14:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 3/8] dmaengine: hisilicon: Add multi-thread support for a DMA channel To: Vinod Koul CC: "Wangzhou (B)" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220625074422.3479591-1-haijie1@huawei.com> <20220625074422.3479591-4-haijie1@huawei.com> From: haijie In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.102.167] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600007.china.huawei.com (7.193.23.208) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org 在 2022/6/27 14:51, - 写道: > -----Original Message----- > From: Vinod Koul [mailto:vkoul@kernel.org] > Sent: Monday, June 27, 2022 2:21 PM > To: haijie > Cc: Wangzhou (B) ; dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 3/8] dmaengine: hisilicon: Add multi-thread support for a DMA channel > > On 25-06-22, 15:44, Jie Hai wrote: >> When we get a DMA channel and try to use it in multiple threads it >> will cause oops and hanging the system. >> >> % echo 100 > /sys/module/dmatest/parameters/threads_per_chan >> % echo 100 > /sys/module/dmatest/parameters/iterations >> % echo 1 > /sys/module/dmatest/parameters/run >> [383493.327077] Unable to handle kernel paging request at virtual >> address dead000000000108 >> [383493.335103] Mem abort info: >> [383493.335103] ESR = 0x96000044 >> [383493.335105] EC = 0x25: DABT (current EL), IL = 32 bits >> [383493.335107] SET = 0, FnV = 0 >> [383493.335108] EA = 0, S1PTW = 0 >> [383493.335109] FSC = 0x04: level 0 translation fault >> [383493.335110] Data abort info: >> [383493.335111] ISV = 0, ISS = 0x00000044 >> [383493.364739] CM = 0, WnR = 1 >> [383493.367793] [dead000000000108] address between user and kernel >> address ranges >> [383493.375021] Internal error: Oops: 96000044 [#1] PREEMPT SMP >> [383493.437574] CPU: 63 PID: 27895 Comm: dma0chan0-copy2 Kdump: >> loaded Tainted: GO 5.17.0-rc4+ #2 >> [383493.457851] pstate: 204000c9 (nzCv daIF +PAN -UAO -TCO -DIT >> -SSBS BTYPE=--) >> [383493.465331] pc : vchan_tx_submit+0x64/0xa0 [383493.469957] lr : >> vchan_tx_submit+0x34/0xa0 >> >> This happens because of data race. Each thread rewrite channels's >> descriptor as soon as device_issue_pending is called. It leads to the >> situation that the driver thinks that it uses the right descriptor in >> interrupt handler while channels's descriptor has been changed by >> other thread. >> >> With current fixes channels's descriptor changes it's value only when >> it has been used. A new descriptor is acquired from >> vc->desc_issued queue that is already filled with descriptors >> that are ready to be sent. Threads have no direct access to DMA >> channel descriptor. Now it is just possible to queue a descriptor for >> further processing. >> >> Fixes: e9f08b65250d ("dmaengine: hisilicon: Add Kunpeng DMA engine >> support") >> Signed-off-by: Jie Hai >> --- >> drivers/dma/hisi_dma.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c index >> 0a0f8a4d168a..0385419be8d5 100644 >> --- a/drivers/dma/hisi_dma.c >> +++ b/drivers/dma/hisi_dma.c >> @@ -271,7 +271,6 @@ static void hisi_dma_start_transfer(struct >> hisi_dma_chan *chan) >> >> vd = vchan_next_desc(&chan->vc); >> if (!vd) { >> - dev_err(&hdma_dev->pdev->dev, "no issued task!\n"); > how is this a fix? > With current fixes, hisi_dma_start_transfer may be called twice for one desc. > If channel's desc is NULL, When hisi_dma_issue_pending >> chan->desc = NULL; >> return; >> } >> @@ -303,7 +302,7 @@ static void hisi_dma_issue_pending(struct dma_chan >> *c) >> >> spin_lock_irqsave(&chan->vc.lock, flags); >> >> - if (vchan_issue_pending(&chan->vc)) >> + if (vchan_issue_pending(&chan->vc) && !chan->desc) > This looks good > >> hisi_dma_start_transfer(chan); >> >> spin_unlock_irqrestore(&chan->vc.lock, flags); @@ -442,11 +441,10 @@ >> static irqreturn_t hisi_dma_irq(int irq, void *data) >> chan->qp_num, chan->cq_head); >> if (FIELD_GET(STATUS_MASK, cqe->w0) == STATUS_SUCC) { >> vchan_cookie_complete(&desc->vd); >> + hisi_dma_start_transfer(chan); > Why should this fix the error reported? > >> } else { >> dev_err(&hdma_dev->pdev->dev, "task error!\n"); >> } >> - >> - chan->desc = NULL; >> } >> >> spin_unlock(&chan->vc.lock); >> -- >> 2.33.0 > -- > ~Vinod > .