From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xianwei Zhao <xianwei.zhao@amlogic.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-amlogic@lists.infradead.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: dma: Add Amlogic A9 SoC DMA
Date: Fri, 27 Feb 2026 10:44:28 +0100 [thread overview]
Message-ID: <9a5e2241-8343-4854-88c0-56022f8a76da@kernel.org> (raw)
In-Reply-To: <4fa16352-5f74-473c-a568-406e3ca24395@amlogic.com>
On 27/02/2026 10:43, Xianwei Zhao wrote:
>>> new file mode 100644
>>> index 000000000000..025ecc42e395
>>> --- /dev/null
>>> +++ b/include/dt-bindings/dma/amlogic-dma.h
>>> @@ -0,0 +1,8 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
>>> +
>>> +#ifndef __DT_BINDINGS_DMA_AMLOGIC_DMA_H__
>>> +#define __DT_BINDINGS_DMA_AMLOGIC_DMA_H__
>>> +
>>> +#define AML_DMA_TYPE_TX 0
>>> +#define AML_DMA_TYPE_RX 1
>> You sure you need AML prefix? Your clock constants do not have AML
>> prefixes. What other constants do you expect here?
>>
>
> I will delete AML prefix in next version.
I assume this is an argument to "dma" phandle (cells), so maybe should
be "DMA_TX/RX"?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-27 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 7:20 [PATCH v4 0/3] Add Amlogic general DMA Xianwei Zhao via B4 Relay
2026-02-27 7:20 ` [PATCH v4 1/3] dt-bindings: dma: Add Amlogic A9 SoC DMA Xianwei Zhao via B4 Relay
2026-02-27 9:18 ` Krzysztof Kozlowski
2026-02-27 9:43 ` Xianwei Zhao
2026-02-27 9:44 ` Krzysztof Kozlowski [this message]
2026-02-27 9:49 ` Xianwei Zhao
2026-02-27 7:20 ` [PATCH v4 2/3] dma: amlogic: Add general DMA driver for A9 Xianwei Zhao via B4 Relay
2026-03-02 8:46 ` Dan Carpenter
2026-02-27 7:20 ` [PATCH v4 3/3] MAINTAINERS: Add an entry for Amlogic DMA driver Xianwei Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5e2241-8343-4854-88c0-56022f8a76da@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox