Re: [PATCH v5 3/7] dmaengine: ptdma: Move common functions to common code

[Basavaraj Natikar <bnatikar@amd.com>]

On 8/28/2024 6:48 PM, Vinod Koul wrote:
> On 08-07-24, 20:14, Basavaraj Natikar wrote:
>> To focus on reusability of ptdma code across modules extract common
>> functions into reusable modules.
>>
>> Reviewed-by: Raju Rangoju <Raju.Rangoju@amd.com>
>> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
>> ---
>>  MAINTAINERS                             | 1 +
>>  drivers/dma/amd/ptdma/ptdma-dev.c       | 2 +-
>>  drivers/dma/amd/ptdma/ptdma-dmaengine.c | 3 +--
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 539bf52410de..97d97ddf26f5 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -952,6 +952,7 @@ M:	Basavaraj Natikar <Basavaraj.Natikar@amd.com>
>>  L:	dmaengine@vger.kernel.org
>>  S:	Maintained
>>  F:	drivers/dma/amd/ae4dma/
>> +F:	drivers/dma/amd/common/
> I think this should be made amd/ to avoid churn when a file is
> added/dropped

Sure, I will remove the common directory and include everything
in the C files.

>
>>  
>>  AMD AXI W1 DRIVER
>>  M:	Kris Chaplin <kris.chaplin@amd.com>
>> diff --git a/drivers/dma/amd/ptdma/ptdma-dev.c b/drivers/dma/amd/ptdma/ptdma-dev.c
>> index a2bf13ff18b6..2bdf418fe556 100644
>> --- a/drivers/dma/amd/ptdma/ptdma-dev.c
>> +++ b/drivers/dma/amd/ptdma/ptdma-dev.c
>> @@ -17,7 +17,7 @@
>>  #include <linux/module.h>
>>  #include <linux/pci.h>
>>  
>> -#include "ptdma.h"
>> +#include "../common/amd_dma.h"
>>  
>>  /* Human-readable error strings */
>>  static char *pt_error_codes[] = {
>> diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
>> index a2e7c2cec15e..66ea10499643 100644
>> --- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
>> +++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
>> @@ -9,8 +9,7 @@
>>   * Author: Gary R Hook <gary.hook@amd.com>
>>   */
>>  
>> -#include "ptdma.h"
>> -#include "../../dmaengine.h"
>> +#include "../common/amd_dma.h"
> So the driver was including old headers and now new, but I dont see any
> functions being moved? Does each patch compile...?

Yes, this compiles. As mentioned in the previous comment, I will remove
the common directory and include everything in the C files.


Thanks,
--
Basavaraj

>