From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4040C77B75 for ; Wed, 3 May 2023 06:37:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbjECGho (ORCPT ); Wed, 3 May 2023 02:37:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjECGhn (ORCPT ); Wed, 3 May 2023 02:37:43 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06086B8; Tue, 2 May 2023 23:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683095862; x=1714631862; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=igBS5JYjxm12TUIwYix1XFx53k9IZdzxu0ykqR6Gpfk=; b=Zb6ACV6P0SlYwB+eM7BFG44wIOMArSSB9mVDE5J021JIZkdHNu+K6VZd WlH18sb5lZTRGd2QoawGRQyVJ+16IcspS1TmVlETl9lT8Mp7Hx/eZnXS2 haWD8oj8c/wPzQx1KxlGHPzENGei+/AY469LtJh1ZAMAUBuhPPOLYCkrk f7fMZ51wbrJBtgmPe8iIhLkgIx78OiouUSGtHN85xJ5mFrTG9bGGeKp63 78aHMsBZPUMe8DThWvFh/vWy/ab8Qs4qxntyq9ntD9CLTCPp8/Q5Kkcyx wVIg4PQyE5nr10ywRw1pDHVyNwg17wH5AiQe4gLf5lNPLX1rTo74Z7AmS g==; X-IronPort-AV: E=McAfee;i="6600,9927,10698"; a="348623712" X-IronPort-AV: E=Sophos;i="5.99,246,1677571200"; d="scan'208";a="348623712" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2023 23:37:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10698"; a="673962607" X-IronPort-AV: E=Sophos;i="5.99,246,1677571200"; d="scan'208";a="673962607" Received: from allen-box.sh.intel.com (HELO [10.239.159.127]) ([10.239.159.127]) by orsmga006.jf.intel.com with ESMTP; 02 May 2023 23:37:36 -0700 Message-ID: <9fb1c0dd-ea78-a3f7-9eac-3154f5d08ad5@linux.intel.com> Date: Wed, 3 May 2023 14:37:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: baolu.lu@linux.intel.com, Will Deacon , David Woodhouse , "Raj, Ashok" , "Liu, Yi L" , "Yu, Fenghua" , "Jiang, Dave" , "Luck, Tony" , "Zanussi, Tom" , "Ranganathan, Narayan" Subject: Re: [PATCH v5 4/7] iommu/vt-d: Factoring out PASID set up helper function Content-Language: en-US To: "Tian, Kevin" , Jacob Pan , LKML , "iommu@lists.linux.dev" , Robin Murphy , Jason Gunthorpe , Joerg Roedel , "dmaengine@vger.kernel.org" , "vkoul@kernel.org" References: <20230427174937.471668-1-jacob.jun.pan@linux.intel.com> <20230427174937.471668-5-jacob.jun.pan@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 4/28/23 5:47 PM, Tian, Kevin wrote: >> From: Jacob Pan >> Sent: Friday, April 28, 2023 1:50 AM >> >> >> +static int dmar_domain_attach_device_pasid(struct dmar_domain *domain, >> + struct intel_iommu *iommu, >> + struct device *dev, ioasid_t pasid) >> +{ >> + int ret; >> + >> + /* PASID table is mandatory for a PCI device in scalable mode. */ >> + if (!sm_supported(iommu) && dev_is_real_dma_subdevice(dev)) >> + return -EOPNOTSUPP; > > "&&" should be "||" > Also should return success instead if this is a RID case. Perhaps, if (!sm_supported(iommu) || dev_is_real_dma_subdevice(dev)) return pasid == RID2PASID ? 0 : -EOPNOTSUPP; Best regards, baolu