From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2036C63798 for ; Wed, 18 Nov 2020 11:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E8F922228 for ; Wed, 18 Nov 2020 11:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727708AbgKRLAH convert rfc822-to-8bit (ORCPT ); Wed, 18 Nov 2020 06:00:07 -0500 Received: from aposti.net ([89.234.176.197]:60144 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727647AbgKRLAH (ORCPT ); Wed, 18 Nov 2020 06:00:07 -0500 Date: Wed, 18 Nov 2020 10:59:48 +0000 From: Paul Cercueil Subject: Re: [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and =?UTF-8?Q?the=0D=0A?= X2000 SoCs. To: Vinod Koul Cc: =?UTF-8?b?5ZGo55Cw5p2w?= , Zubair.Kakakhel@imgtec.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, yanfei.li@ingenic.com, sernia.zhou@foxmail.com, zhenwenjin@gmail.com Message-Id: In-Reply-To: <20201118105511.GM50232@vkoul-mobl> References: <20201107122016.89859-1-zhouyanjie@wanyeetech.com> <20201118105511.GM50232@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Le mer. 18 nov. 2020 à 16:25, Vinod Koul a écrit : > On 10-11-20, 08:54, Paul Cercueil wrote: >> Hi Zhou, >> >> Le sam. 7 nov. 2020 à 20:20, 周琰杰 (Zhou Yanjie) >> a écrit : >> > Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC >> from >> > Ingenic. >> > >> > 周琰杰 (Zhou Yanjie) (2): >> > dt-bindings: dmaengine: Add JZ4775 bindings. >> > dt-bindings: dmaengine: Add X2000 bindings. >> > >> > include/dt-bindings/dma/jz4775-dma.h | 44 >> +++++++++++++++++++++++++++++ >> > include/dt-bindings/dma/x2000-dma.h | 54 >> > ++++++++++++++++++++++++++++++++++++ >> >> If that's up to me, these macros aren't really needed, and you can >> put the >> values directly in the dma cells. This is done already in >> jz4740.dtsi, >> jz4725b.dtsi and jz4770.dtsi. > > But that is not really nice, it is good to define these rather than > put > numbers, the include/dt-bindings exists for this sole reason! The macros in include/dt-bindings exist for when the C code also needs them (e.g. IRQ_TYPE_EDGE_RISING), and not when they are only used in devicetree. Things like IRQ numbers are never defined in include/dt-bindings, because they don't have to be... -Paul