From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78826C433E0 for ; Mon, 21 Dec 2020 04:56:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46FC922CB2 for ; Mon, 21 Dec 2020 04:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbgLUE43 (ORCPT ); Sun, 20 Dec 2020 23:56:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726552AbgLUE42 (ORCPT ); Sun, 20 Dec 2020 23:56:28 -0500 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FEF4C0613D3 for ; Sun, 20 Dec 2020 20:55:47 -0800 (PST) Received: by mail-yb1-xb31.google.com with SMTP id y128so7766402ybf.10 for ; Sun, 20 Dec 2020 20:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XBn6ZaN2/e80TT6li1FQJn5DAlS/Vz3aVp5cdanhwx0=; b=eD8gurwuCeouZfOp095joie+CkUfk2Qq8jzl/CxCPCYo1FDAsZDtayDjD2XMxGh7pp Vx2E+zd5zQHvmskowfnDUMSGluzZ9BYqwwySe7dbVtEgeiBDefleuDiea/TLtIoi0OaB Ol1sEMZ4mL4D2varqEMMjBDc1qcPd0u/rw9fFy8IlP7hYUdgTt9HHMaELLE5GxKplYVI y4KLvoLPSxuh2xT7I5ixlF1920p28igJ1Z/goiUNto2PzJxck7VTvUwjdK0CLpHinBAH FfqPKBbPQvlr+NbhdQRCs0N2Ci97vS8EPx62uXqV+tmtU/V/ayXNTU9cbFpsy8GwrIhC R4ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XBn6ZaN2/e80TT6li1FQJn5DAlS/Vz3aVp5cdanhwx0=; b=f8E6iKejkwMRPth5A0tAwfC3Nx1WfSy10kcBY+8BsjlyhmT74zo+5n7YUE0DXaR3/m LRxDdSE2WM/C4/fHy5IA8IzGx069mOK5mOYpFR0PRsBkgMWxp4FTHVjkhfOJ34Wpy3A4 D92fOOZFAGXrdsRCAz31haXFPaqzqOTAVshSEfbweSgFHs9XEeOMg8EMntzkS5VjaNkS djy0UoAdLNEdwKIwVqg2qM6dh6vbP5hQPh47wH2VAQr/W9pIOZYXH9igQpX341E/KhNl yojoIlu7D97B3Dhd+APRMJd03LPzJIbsJibPw//P0KYBLB5hiNVZ2Nu8FlyHxmyJ7cyh InfA== X-Gm-Message-State: AOAM532btvxHG9bzb1KfNwehxScrBtRrSROgUrX+Na5wU4OyUcOEBmzs GT6GSLYYCHiRsgFoGjxW67w5Fi/g0W7xdA== X-Google-Smtp-Source: ABdhPJw+J9b0p/Ufag3WxMIn6M+MA093oET0b4OpVhuLP6+98+UVeWLiJmyyucgkbeZWJ/XgVAltTw== X-Received: by 2002:a05:6830:17c7:: with SMTP id p7mr10742164ota.21.1608522636756; Sun, 20 Dec 2020 19:50:36 -0800 (PST) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id i126sm2408687oif.22.2020.12.20.19.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Dec 2020 19:50:35 -0800 (PST) Date: Sun, 20 Dec 2020 19:51:20 -0800 From: Bjorn Andersson To: Xiaoming Ni Cc: vkoul@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, agross@kernel.org, wangle6@huawei.com Subject: Re: [PATCH] dma/qcom/gpi: Fixes a format mismatch Message-ID: References: <20201218104137.59200-1-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201218104137.59200-1-nixiaoming@huawei.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Fri 18 Dec 02:41 PST 2020, Xiaoming Ni wrote: > drivers/dma/qcom/gpi.c:1419:3: warning: format '%lu' expects argument of > type 'long unsigned int', but argument 8 has type 'size_t {aka unsigned > int}' [-Wformat=] > drivers/dma/qcom/gpi.c:1427:31: warning: format '%lu' expects argument of > type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned > int}' [-Wformat=] > drivers/dma/qcom/gpi.c:1447:3: warning: format '%llx' expects argument of > type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka > unsigned int}' [-Wformat=] > drivers/dma/qcom/gpi.c:1447:3: warning: format '%llx' expects argument of > type 'long long unsigned int', but argument 5 has type 'phys_addr_t {aka > unsigned int}' [-Wformat=] > Reviewed-by: Bjorn Andersson > Signed-off-by: Xiaoming Ni > --- > drivers/dma/qcom/gpi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index d2334f535de2..556c070a514c 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -1416,7 +1416,7 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements, > len = 1 << bit; > ring->alloc_size = (len + (len - 1)); > dev_dbg(gpii->gpi_dev->dev, > - "#el:%u el_size:%u len:%u actual_len:%llu alloc_size:%lu\n", > + "#el:%u el_size:%u len:%u actual_len:%llu alloc_size:%zu\n", > elements, el_size, (elements * el_size), len, > ring->alloc_size); > > @@ -1424,7 +1424,7 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements, > ring->alloc_size, > &ring->dma_handle, GFP_KERNEL); > if (!ring->pre_aligned) { > - dev_err(gpii->gpi_dev->dev, "could not alloc size:%lu mem for ring\n", > + dev_err(gpii->gpi_dev->dev, "could not alloc size:%zu mem for ring\n", > ring->alloc_size); > return -ENOMEM; > } > @@ -1444,8 +1444,8 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements, > smp_wmb(); > > dev_dbg(gpii->gpi_dev->dev, > - "phy_pre:0x%0llx phy_alig:0x%0llx len:%u el_size:%u elements:%u\n", > - ring->dma_handle, ring->phys_addr, ring->len, > + "phy_pre:%pad phy_alig:%pa len:%u el_size:%u elements:%u\n", > + &ring->dma_handle, &ring->phys_addr, ring->len, > ring->el_size, ring->elements); > > return 0; > -- > 2.27.0 >