From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: agross@kernel.org, dan.j.williams@intel.com, vkoul@kernel.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] qcom: bam_dma: Delete useless kfree code
Date: Wed, 16 Dec 2020 12:32:52 -0600 [thread overview]
Message-ID: <X9pS1F91OxYMCMpI@builder.lan> (raw)
In-Reply-To: <20201216130649.13979-1-zhengyongjun3@huawei.com>
On Wed 16 Dec 07:06 CST 2020, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
> Therefore, goto expression is no longer needed, so simplify it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/dma/qcom/bam_dma.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
> index 4eeb8bb27279..78df217b3f6c 100644
> --- a/drivers/dma/qcom/bam_dma.c
> +++ b/drivers/dma/qcom/bam_dma.c
> @@ -630,7 +630,7 @@ static struct dma_async_tx_descriptor *bam_prep_slave_sg(struct dma_chan *chan,
> GFP_NOWAIT);
>
> if (!async_desc)
> - goto err_out;
> + return NULL;
>
> if (flags & DMA_PREP_FENCE)
> async_desc->flags |= DESC_FLAG_NWD;
> @@ -670,10 +670,6 @@ static struct dma_async_tx_descriptor *bam_prep_slave_sg(struct dma_chan *chan,
> }
>
> return vchan_tx_prep(&bchan->vc, &async_desc->vd, flags);
> -
> -err_out:
> - kfree(async_desc);
> - return NULL;
> }
>
> /**
> --
> 2.22.0
>
next prev parent reply other threads:[~2020-12-16 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 13:06 [PATCH -next] qcom: bam_dma: Delete useless kfree code Zheng Yongjun
2020-12-16 18:32 ` Bjorn Andersson [this message]
2020-12-21 16:23 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9pS1F91OxYMCMpI@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).