From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9B4C4361B for ; Wed, 16 Dec 2020 18:33:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A23C23AA3 for ; Wed, 16 Dec 2020 18:33:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731045AbgLPSdg (ORCPT ); Wed, 16 Dec 2020 13:33:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731044AbgLPSdg (ORCPT ); Wed, 16 Dec 2020 13:33:36 -0500 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54B30C0617A6 for ; Wed, 16 Dec 2020 10:32:56 -0800 (PST) Received: by mail-oi1-x22d.google.com with SMTP id q25so28606341oij.10 for ; Wed, 16 Dec 2020 10:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TOKrfljSwb0iquFcwhx16t0mlmb8z327F7siyfgd+Io=; b=yd2cqrPLfduV1Hea+fTiIe+/9IkIEb6MKlQIilXuDL4916KjY5zK/R3iTzbUDPdN6Y LRpSlA9st56gL6Hpw+u8O3sPlKB3aPyOu+Tghlrzn7j/4DOYqGl04UCbHqdMK2uLSxT4 zyEt0D4fi6/beYoXjvEb/zDZxfQhTFOKvIvtowB7eJR5cdFUU58CN7uHi8VhlrTK2IwF da7AZZCsYZajEZ1Q9gV1DS4TMYLt1MwuFWJ6MdTtovrbdDiJON9cJY8fEFdmQISS2mpL 2pHMd83p47SRJN0l95Nc3w6SFV76WZR9gnVQCx+IP1Thu++ADUU8fhlRCLtoxYZSa0bK VOfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TOKrfljSwb0iquFcwhx16t0mlmb8z327F7siyfgd+Io=; b=iT4k6boRK/UABpzfBpjFggHooETsQx5xoDSVORGaqa4OMJzTwpwbesQZf4CpK1IWl1 FkKPXAisl+XkvkRZeyuyv2l2GSkf70hOzCTmeBJV1EU8qpmflDiJWyYtqqaQw77lC4mL zAx8DkFBDjjqbwMx1ld7VWiRsxSJuf/IcnXymj7Hy7ITZfs64fd53VC6KAD0EvhgDoo4 XTzkRa75eqUEpXNwW2tNMgm/cGHrYMxRjaVnZVxYZPrFUHLn92o3lo2FjEGsWuMl5ZMD /mGfDLM4iAavDD3Z4r7s/x0w8V8aCUVLal8ypuI7zjvsrgxk3yGC8RNnbn5ITSd5Llu8 nRKg== X-Gm-Message-State: AOAM531wM6Oq2Z+hbANYBa1mAcd19q2rEUFjn+nheHM9pKQ8xEiumQ9i OTaSWVJxyRFB9dlC5NgCFIVZUQ== X-Google-Smtp-Source: ABdhPJwRU+MItydmtpCEjuBcCjGgBaYAvNj1wCz3tWiuHYbakckuOaLYeu9+147ay8nGxmUWevswhQ== X-Received: by 2002:aca:c0c6:: with SMTP id q189mr2738473oif.178.1608143575260; Wed, 16 Dec 2020 10:32:55 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z63sm615486otb.20.2020.12.16.10.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 10:32:54 -0800 (PST) Date: Wed, 16 Dec 2020 12:32:52 -0600 From: Bjorn Andersson To: Zheng Yongjun Cc: agross@kernel.org, dan.j.williams@intel.com, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] qcom: bam_dma: Delete useless kfree code Message-ID: References: <20201216130649.13979-1-zhengyongjun3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201216130649.13979-1-zhengyongjun3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed 16 Dec 07:06 CST 2020, Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > Therefore, goto expression is no longer needed, so simplify it. > > Signed-off-by: Zheng Yongjun Reviewed-by: Bjorn Andersson > --- > drivers/dma/qcom/bam_dma.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c > index 4eeb8bb27279..78df217b3f6c 100644 > --- a/drivers/dma/qcom/bam_dma.c > +++ b/drivers/dma/qcom/bam_dma.c > @@ -630,7 +630,7 @@ static struct dma_async_tx_descriptor *bam_prep_slave_sg(struct dma_chan *chan, > GFP_NOWAIT); > > if (!async_desc) > - goto err_out; > + return NULL; > > if (flags & DMA_PREP_FENCE) > async_desc->flags |= DESC_FLAG_NWD; > @@ -670,10 +670,6 @@ static struct dma_async_tx_descriptor *bam_prep_slave_sg(struct dma_chan *chan, > } > > return vchan_tx_prep(&bchan->vc, &async_desc->vd, flags); > - > -err_out: > - kfree(async_desc); > - return NULL; > } > > /** > -- > 2.22.0 >