From: Vinod Koul <vkoul@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: peter.ujfalusi@gmail.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] dmaengine: ti: edma: Remove the unused function edma_and()
Date: Wed, 19 Oct 2022 19:16:07 +0530 [thread overview]
Message-ID: <Y0//nxmB2CEjFvMp@matsya> (raw)
In-Reply-To: <20221018083820.25297-1-jiapeng.chong@linux.alibaba.com>
On 18-10-22, 16:38, Jiapeng Chong wrote:
> The function edma_and() is defined in the edma.c file, but not called
> elsewhere, so remove this unused function.
>
> drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Where is this report?
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/dma/ti/edma.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index fa06d7e6d8e3..9ea91c640c32 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
> edma_write(ecc, offset, val);
> }
>
> -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
> -{
> - unsigned val = edma_read(ecc, offset);
> -
> - val &= and;
> - edma_write(ecc, offset, val);
> -}
> -
> static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or)
> {
> unsigned val = edma_read(ecc, offset);
> --
> 2.20.1.7.g153144c
--
~Vinod
next prev parent reply other threads:[~2022-10-19 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 8:38 [PATCH] dmaengine: ti: edma: Remove the unused function edma_and() Jiapeng Chong
2022-10-19 13:46 ` Vinod Koul [this message]
[not found] ` <354896d0-3a48-44a1-81bf-8e46caf55a7e.jiapeng.chong@linux.alibaba.com>
2022-11-04 14:40 ` 回复:[PATCH] " Vinod Koul
2022-10-26 17:21 ` [PATCH] " Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0//nxmB2CEjFvMp@matsya \
--to=vkoul@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=dmaengine@vger.kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox