From: Vinod Koul <vkoul@kernel.org>
To: "Martin Povišer" <povik+lin@cutebit.org>
Cc: asahi@lists.linux.dev, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 2/2] dmaengine: apple-admac: Allocate cache SRAM to channels
Date: Wed, 19 Oct 2022 18:33:49 +0530 [thread overview]
Message-ID: <Y0/1tfNX1hwX6EFk@matsya> (raw)
In-Reply-To: <20221003081053.1826-2-povik+lin@cutebit.org>
On 03-10-22, 10:10, Martin Povišer wrote:
> There's a previously unknown part of the controller interface: We have
> to assign SRAM carveouts to channels to store their in-flight samples
> in. So, obtain the size of the SRAM from a read-only register and divide
> it into 2K blocks for allocation to channels. The FIFO depths we
> configure will always fit into 2K.
>
> (This fixes audio artifacts during simultaneous playback/capture on
> multiple channels -- which looking back is fully accounted for by having
> had the caches in the DMA controller overlap in memory.)
This fails to apply for me, please rebase and resend...
While fixing, I think it would make sense to s/alloced/allocated perhpas
and also fix the indent in split lines to align with preceeding brace
(hint checkpatch --strict would tell you)
--
~Vinod
prev parent reply other threads:[~2022-10-19 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 8:10 [PATCH RESEND 1/2] dmaengine: apple-admac: Fix grabbing of channels in of_xlate Martin Povišer
2022-10-03 8:10 ` [PATCH RESEND 2/2] dmaengine: apple-admac: Allocate cache SRAM to channels Martin Povišer
2022-10-19 13:03 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0/1tfNX1hwX6EFk@matsya \
--to=vkoul@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=povik+lin@cutebit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox