public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Zhou Wang <wangzhou1@hisilicon.com>,
	Zhenfa Qiu <qiuzhenfa@hisilicon.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: HISI_DMA should depend on ARCH_HISI
Date: Wed, 28 Dec 2022 16:41:51 +0530	[thread overview]
Message-ID: <Y6wkd93CvGW/iOQR@matsya> (raw)
In-Reply-To: <363a1816d36cd3cf604d88ec90f97c75f604de64.1669044190.git.geert+renesas@glider.be>

On 21-11-22, 16:23, Geert Uytterhoeven wrote:
> The HiSilicon DMA Engine is only present on HiSilicon SoCs.  Hence add a
> dependency on ARCH_HISI, to prevent asking the user about this driver
> when configuring a kernel without HiSilicon SoC support.
> 
> Fixes: e9f08b65250d73ab ("dmaengine: hisilicon: Add Kunpeng DMA engine support")

My script warns of bad tag, so I looked up.. this one uses 16 chars of
SHA1... checkpatch also complains: Please use correct Fixes: style
'Fixes: <12 chars of sha1>...

I guess lots of parts assume that it shall be _exactly_ 12!

I have applied it ..

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index b9d54f20812f794b..67323afe9fcad137 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -245,7 +245,7 @@ config FSL_RAID
>  
>  config HISI_DMA
>  	tristate "HiSilicon DMA Engine support"
> -	depends on ARM64 || COMPILE_TEST
> +	depends on ARCH_HISI || COMPILE_TEST
>  	depends on PCI_MSI
>  	select DMA_ENGINE
>  	select DMA_VIRTUAL_CHANNELS
> -- 
> 2.25.1

-- 
~Vinod

      reply	other threads:[~2022-12-28 11:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 15:23 [PATCH] dmaengine: HISI_DMA should depend on ARCH_HISI Geert Uytterhoeven
2022-12-28 11:11 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6wkd93CvGW/iOQR@matsya \
    --to=vkoul@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiuzhenfa@hisilicon.com \
    --cc=wangzhou1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox