From: Vinod Koul <vkoul@kernel.org>
To: Eric Pilmore <epilmore@gigaio.com>
Cc: sanju.mehta@amd.com, dmaengine@vger.kernel.org
Subject: Re: [PATCH] ptdma: pt_core_execute_cmd() should use spinlock
Date: Thu, 19 Jan 2023 19:00:09 +0530 [thread overview]
Message-ID: <Y8lF4YNal4rS9jN9@matsya> (raw)
In-Reply-To: <20230119033907.35071-1-epilmore@gigaio.com>
On 18-01-23, 19:39, Eric Pilmore wrote:
> From: Eric Pilmore <epilmore@gigaio.com>
>
> The interrupt handler (pt_core_irq_handler()) of the ptdma
> driver can be called from interrupt context. The code flow
> in this function can lead down to pt_core_execute_cmd() which
> will attempt to grab a mutex, which is not appropriate in
> interrupt context and ultimately leads to a kernel panic.
> The fix here changes this mutex to a spinlock, which has
> been verified to resolve the issue.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2023-01-19 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 3:39 [PATCH] ptdma: pt_core_execute_cmd() should use spinlock Eric Pilmore
2023-01-19 13:30 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lF4YNal4rS9jN9@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=epilmore@gigaio.com \
--cc=sanju.mehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox